Lucene - Core
  1. Lucene - Core
  2. LUCENE-5799

speed up DocValuesConsumer.mergeNumericField

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This method (used for both numeric docvalues and norms) is a little slow:

      • does some boxing for no good reason (can just use a boolean instead)
      • checks docsWithField always, instead of only when value == 0. This can cause unnecessary i/o.

        Activity

        Hide
        Robert Muir added a comment -

        Trivial patch.

        Show
        Robert Muir added a comment - Trivial patch.
        Hide
        Adrien Grand added a comment -

        +1

        Show
        Adrien Grand added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1607065 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1607065 ]

        LUCENE-5799: optimize numeric docvalues merging

        Show
        ASF subversion and git services added a comment - Commit 1607065 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1607065 ] LUCENE-5799 : optimize numeric docvalues merging
        Hide
        ASF subversion and git services added a comment -

        Commit 1607067 from Robert Muir in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1607067 ]

        LUCENE-5799: optimize numeric docvalues merging

        Show
        ASF subversion and git services added a comment - Commit 1607067 from Robert Muir in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1607067 ] LUCENE-5799 : optimize numeric docvalues merging

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development