[LUCENE-5784] CommonTermsQuery HighFreq MUST not applied if lowFreq terms

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 4.8.1
• Component/s: core/query/scoring
• Lucene Fields: New, Patch Available
• Assignee: Simon Willnauer
• Reporter: Clinton Gormley
• Created: 22/Jun/14 07:28
• Updated: 28/Aug/22 14:10
• Resolved: 07/Jul/14 15:10

Description

When a CommonTermsQuery has high and low frequency terms, the highFreq terms Boolean query is always added as a SHOULD clause, even if highFreqOccur is set to MUST:

new CommonTermsQuery(Occur.MUST, Occur.MUST,0.1);

My patch sets the top level Boolean query's minimum should match to 1 to ensure that the SHOULD clause must match. Not sure if this is the correct approach, or if it should just add the highFreq query as a MUST clause instead?