Lucene - Core
  1. Lucene - Core
  2. LUCENE-575

SpellChecker min score is increased by time

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 2.1
    • Component/s: core/search
    • Labels:
      None

      Description

      The minimum score, an instance variable, is modified in a search. That is wrong, since it makes it 1. thread unsafe and 2. not working.

      Lucky enought it is only used from the one and same method call, so I simply compied the instance variable to a local method variable.

      float min = this.min;

        Activity

        Karl Wettin created issue -
        Hide
        Karl Wettin added a comment -

        I would have to say this is for 2.0 as the SpellCheck does not work without it in most cases.

        Show
        Karl Wettin added a comment - I would have to say this is for 2.0 as the SpellCheck does not work without it in most cases.
        Karl Wettin made changes -
        Field Original Value New Value
        Attachment SpellChecker.java.diff [ 12334466 ]
        Hide
        Karl Wettin added a comment -

        This is just another push to get the patch committed.

        Show
        Karl Wettin added a comment - This is just another push to get the patch committed.
        Hide
        Yonik Seeley added a comment -

        I just commited this. Thanks Karl!

        Show
        Yonik Seeley added a comment - I just commited this. Thanks Karl!
        Yonik Seeley made changes -
        Fix Version/s 2.1 [ 12310854 ]
        Resolution Fixed [ 1 ]
        Assignee Yonik Seeley [ yseeley@gmail.com ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Michael McCandless added a comment -

        Closing all issues that were resolved for 2.1.

        Show
        Michael McCandless added a comment - Closing all issues that were resolved for 2.1.
        Michael McCandless made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12372343 ] Default workflow, editable Closed status [ 12562370 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12562370 ] jira [ 12583364 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        9d 6m 1 Yonik Seeley 02/Jun/06 05:37
        Resolved Resolved Closed Closed
        270d 13h 32m 1 Michael McCandless 27/Feb/07 18:10

          People

          • Assignee:
            Yonik Seeley
            Reporter:
            Karl Wettin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development