Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 4.8.1
    • Fix Version/s: 4.9, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      We already expose the ram usage inside the FlushPolicy via DWFlushControl and since we now have Accountable I think IW should implement it too to get more info about it's current RAM usage.

      1. LUCENE-5756.patch
        8 kB
        Simon Willnauer
      2. LUCENE-5756.patch
        15 kB
        Simon Willnauer
      3. LUCENE-5756.patch
        6 kB
        Simon Willnauer

        Issue Links

          Activity

          Hide
          Simon Willnauer added a comment -

          here is a patch

          Show
          Simon Willnauer added a comment - here is a patch
          Hide
          Michael McCandless added a comment -

          +1

          Show
          Michael McCandless added a comment - +1
          Hide
          Adrien Grand added a comment -

          +1

          would be nice to also update BufferedUpdatesStream and others for consistency, even if these are only internal APIs?

          Show
          Adrien Grand added a comment - +1 would be nice to also update BufferedUpdatesStream and others for consistency, even if these are only internal APIs?
          Hide
          Simon Willnauer added a comment -

          updated patch moving more internal classes to use Accountable - I think it's ready?

          Show
          Simon Willnauer added a comment - updated patch moving more internal classes to use Accountable - I think it's ready?
          Hide
          Adrien Grand added a comment -

          +1

          Show
          Adrien Grand added a comment - +1
          Hide
          Michael McCandless added a comment -

          Should IW's ramSizeInBytes just return ramBytesUsed?

          Show
          Michael McCandless added a comment - Should IW's ramSizeInBytes just return ramBytesUsed?
          Hide
          Robert Muir added a comment -

          Can you fix your IDE not to reorder java.xxx imports after org.apache.lucene?

          The official lucene style inserted in 'ant eclipse' for example has it the other way around. This is going to create a ton of noise and merge conflicts otherwise.

          Show
          Robert Muir added a comment - Can you fix your IDE not to reorder java.xxx imports after org.apache.lucene? The official lucene style inserted in 'ant eclipse' for example has it the other way around. This is going to create a ton of noise and merge conflicts otherwise.
          Hide
          Simon Willnauer added a comment -

          fixed imports... this is annoying why idea doesn't have this by default... anyhow...

          I also delegate to ramBytesUsed now... I will remove that in master anyway...

          Show
          Simon Willnauer added a comment - fixed imports... this is annoying why idea doesn't have this by default... anyhow... I also delegate to ramBytesUsed now... I will remove that in master anyway...
          Hide
          Robert Muir added a comment -

          Is there something wrong with the 'ant idea' configuration in lucene that it causes this by default? Besides it automatically reordering, Why is the order of Idea backwards from the correct order? If we can fix these things in our 'ant idea' configuration that would be awesome.

          Show
          Robert Muir added a comment - Is there something wrong with the 'ant idea' configuration in lucene that it causes this by default? Besides it automatically reordering, Why is the order of Idea backwards from the correct order? If we can fix these things in our 'ant idea' configuration that would be awesome.
          Hide
          ASF subversion and git services added a comment -

          Commit 1602388 from Simon Willnauer in branch 'dev/trunk'
          [ https://svn.apache.org/r1602388 ]

          LUCENE-5756: Implement Accountable from IndexWriter

          Show
          ASF subversion and git services added a comment - Commit 1602388 from Simon Willnauer in branch 'dev/trunk' [ https://svn.apache.org/r1602388 ] LUCENE-5756 : Implement Accountable from IndexWriter
          Hide
          Simon Willnauer added a comment -

          FYI I fixed the template in trunk and 4.x

          Show
          Simon Willnauer added a comment - FYI I fixed the template in trunk and 4.x
          Hide
          ASF subversion and git services added a comment -

          Commit 1602393 from Simon Willnauer in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1602393 ]

          LUCENE-5756: Implement Accountable from IndexWriter

          Show
          ASF subversion and git services added a comment - Commit 1602393 from Simon Willnauer in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1602393 ] LUCENE-5756 : Implement Accountable from IndexWriter
          Hide
          Robert Muir added a comment -

          Very awesome, thank you! I think for a long time this has been contributing noise to the codebase.

          Show
          Robert Muir added a comment - Very awesome, thank you! I think for a long time this has been contributing noise to the codebase.

            People

            • Assignee:
              Simon Willnauer
              Reporter:
              Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development