Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: core/search
    • Labels:
      None

      Description

      filing as bug for tracking/refrence...

      On May 16, 2006, at 3:33 AM, Chris Hostetter wrote:

      > SpanNodeQuery's hashCode method makes two refrences to
      > include.hashCode(),
      > but none to exclude.hashCode() ... this is a mistake yes/no?

      Date: Tue, 16 May 2006 05:57:15 -0400
      From: Erik Hatcher
      To: java-dev@lucene.apache.org
      Subject: Re: SpanNotQuery.hashCode cut/paste error?

      Yes, this is a mistake. I'm happy to fix it, but looks like you have
      other patches in progress.

        Activity

        Hide
        hossman Hoss Man added a comment -

        simple one line fix commited...

        Index: src/java/org/apache/lucene/search/spans/SpanNotQuery.java
        ===================================================================
        — src/java/org/apache/lucene/search/spans/SpanNotQuery.java (revision 407485)
        +++ src/java/org/apache/lucene/search/spans/SpanNotQuery.java (working copy)
        @@ -172,7 +172,7 @@
        public int hashCode() {
        int h = include.hashCode();
        h = (h<<1) | (h >>> 31); // rotate left

        • h ^= include.hashCode();
          + h ^= exclude.hashCode();
          h = (h<<1) | (h >>> 31); // rotate left
          h ^= Float.floatToRawIntBits(getBoost());
          return h;
        Show
        hossman Hoss Man added a comment - simple one line fix commited... Index: src/java/org/apache/lucene/search/spans/SpanNotQuery.java =================================================================== — src/java/org/apache/lucene/search/spans/SpanNotQuery.java (revision 407485) +++ src/java/org/apache/lucene/search/spans/SpanNotQuery.java (working copy) @@ -172,7 +172,7 @@ public int hashCode() { int h = include.hashCode(); h = (h<<1) | (h >>> 31); // rotate left h ^= include.hashCode(); + h ^= exclude.hashCode(); h = (h<<1) | (h >>> 31); // rotate left h ^= Float.floatToRawIntBits(getBoost()); return h;

          People

          • Assignee:
            hossman Hoss Man
            Reporter:
            hossman Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development