Lucene - Core
  1. Lucene - Core
  2. LUCENE-5717

Postings highlighter support for multi term queries within filtered and constant score queries

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.8.1
    • Fix Version/s: 4.9, 6.0
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      The automata extraction that is done to make multi term queries work with the postings highlighter does support boolean queries but it should also support other compound queries like filtered and constant score.

        Activity

        Hide
        Luca Cavanna added a comment -

        First patch attached. At this time there's no generic way to retrieve sub-queries from compound queries, thus I could only add two more ifs to the existing extractAutomata method. Maybe it's worth discussing if there's a way to make this more generic in a separate issue. Also not sure if there are others compound queries that I missed.

        Show
        Luca Cavanna added a comment - First patch attached. At this time there's no generic way to retrieve sub-queries from compound queries, thus I could only add two more ifs to the existing extractAutomata method. Maybe it's worth discussing if there's a way to make this more generic in a separate issue. Also not sure if there are others compound queries that I missed.
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1598755 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1598755 ]

        LUCENE-5717: Postings highlighter support for multi term queries within filtered and constant score queries

        Show
        ASF subversion and git services added a comment - Commit 1598755 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1598755 ] LUCENE-5717 : Postings highlighter support for multi term queries within filtered and constant score queries
        Hide
        ASF subversion and git services added a comment -

        Commit 1598756 from Robert Muir in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1598756 ]

        LUCENE-5717: Postings highlighter support for multi term queries within filtered and constant score queries

        Show
        ASF subversion and git services added a comment - Commit 1598756 from Robert Muir in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1598756 ] LUCENE-5717 : Postings highlighter support for multi term queries within filtered and constant score queries
        Hide
        Robert Muir added a comment -

        Thanks Luca!

        Show
        Robert Muir added a comment - Thanks Luca!

          People

          • Assignee:
            Unassigned
            Reporter:
            Luca Cavanna
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development