Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.9, 6.0
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Spinoff from here: http://markmail.org/message/7kjlaizqdh7kst4d. We should consolidate the various IW.deleteDocuments().

        Activity

        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Shai Erera added a comment -

        Patch removes the single-arg delDocs Term/Query variants. Everything compiles and tests pass. I'll sun jdocs tests too, though eclipse showed no additional errors about referencing those methods.

        Do you think it's OK to backport to 4x? The only concern I have is if apps will upgrade to e.g. 4.9 by only dropping the 4.9 jar, not compiling their code as well. I don't know if people still do that though ... . Anyway, if we want to keep that, we can deprecate them in 4x.

        Show
        Shai Erera added a comment - Patch removes the single-arg delDocs Term/Query variants. Everything compiles and tests pass. I'll sun jdocs tests too, though eclipse showed no additional errors about referencing those methods. Do you think it's OK to backport to 4x? The only concern I have is if apps will upgrade to e.g. 4.9 by only dropping the 4.9 jar, not compiling their code as well. I don't know if people still do that though ... . Anyway, if we want to keep that, we can deprecate them in 4x.
        Hide
        Michael McCandless added a comment -

        I think just drop them in 4.x.

        Show
        Michael McCandless added a comment - I think just drop them in 4.x.
        Hide
        ASF subversion and git services added a comment -

        Commit 1596296 from Shai Erera in branch 'dev/trunk'
        [ https://svn.apache.org/r1596296 ]

        LUCENE-5679: remove the single-parameter deleteDocuments() versions, in favor of the vararg ones

        Show
        ASF subversion and git services added a comment - Commit 1596296 from Shai Erera in branch 'dev/trunk' [ https://svn.apache.org/r1596296 ] LUCENE-5679 : remove the single-parameter deleteDocuments() versions, in favor of the vararg ones
        Hide
        ASF subversion and git services added a comment -

        Commit 1596301 from Shai Erera in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1596301 ]

        LUCENE-5679: remove the single-parameter deleteDocuments() versions, in favor of the vararg ones

        Show
        ASF subversion and git services added a comment - Commit 1596301 from Shai Erera in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1596301 ] LUCENE-5679 : remove the single-parameter deleteDocuments() versions, in favor of the vararg ones
        Hide
        Shai Erera added a comment -

        Committed to trunk and 4x. Thanks Mike!

        Show
        Shai Erera added a comment - Committed to trunk and 4x. Thanks Mike!
        Hide
        ASF subversion and git services added a comment -

        Commit 1596304 from Shai Erera in branch 'dev/trunk'
        [ https://svn.apache.org/r1596304 ]

        LUCENE-5679: leftover jdoc fix

        Show
        ASF subversion and git services added a comment - Commit 1596304 from Shai Erera in branch 'dev/trunk' [ https://svn.apache.org/r1596304 ] LUCENE-5679 : leftover jdoc fix
        Hide
        ASF subversion and git services added a comment -

        Commit 1596306 from Shai Erera in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1596306 ]

        LUCENE-5679: leftover jdoc fix

        Show
        ASF subversion and git services added a comment - Commit 1596306 from Shai Erera in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1596306 ] LUCENE-5679 : leftover jdoc fix
        Hide
        Uwe Schindler added a comment -

        See my comment on the mailing list about 4.x:

        Hi,

        this is a binary backwards break in 4.x, because the method signature, user's code was compiled against in previous versions, is removed for no reason. In 4.x I would keep the one-arg methods, but just let it delegate to the vararg version. The javadocs can stay the same.
        In fact this change requires to recompile your source-code (source-code compatibility is ensured) but does not provide binary compatibility.

        Uwe

        Show
        Uwe Schindler added a comment - See my comment on the mailing list about 4.x: Hi, this is a binary backwards break in 4.x, because the method signature, user's code was compiled against in previous versions, is removed for no reason. In 4.x I would keep the one-arg methods, but just let it delegate to the vararg version. The javadocs can stay the same. In fact this change requires to recompile your source-code (source-code compatibility is ensured) but does not provide binary compatibility. Uwe
        Hide
        Shai Erera added a comment -

        I'm not sure how critical it is Uwe. Yes, it means users need to recompile their app's code, but this is minor? It's not like they need to change the code, only recompile it. I am still waiting for someone to say that he upgrades his search app to a newer Lucene version by simply dropping the new jar .... 4.9 already includes changes to runtime behavior and some back-compat changes.

        Show
        Shai Erera added a comment - I'm not sure how critical it is Uwe. Yes, it means users need to recompile their app's code, but this is minor? It's not like they need to change the code, only recompile it. I am still waiting for someone to say that he upgrades his search app to a newer Lucene version by simply dropping the new jar .... 4.9 already includes changes to runtime behavior and some back-compat changes.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development