Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.8.1, 4.9, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      When I was comparing performance of different UUIDs, I noticed that TMP was merging too soon and picking non-ideal merges as a result. The fix is silly:

      Index: lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java
      ===================================================================
      — lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java (revision 1593975)
      +++ lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java (working copy)
      @@ -361,7 +361,7 @@
      return spec;
      }

      • if (eligible.size() >= allowedSegCountInt) {
        + if (eligible.size() > allowedSegCountInt) {

      // OK we are over budget – find best merge!
      MergeScore bestScore = null;

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1594059 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1594059 ]

        LUCENE-5668: fix ob1 in TieredMergePolicy

        Show
        ASF subversion and git services added a comment - Commit 1594059 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1594059 ] LUCENE-5668 : fix ob1 in TieredMergePolicy
        Hide
        ASF subversion and git services added a comment -

        Commit 1594062 from Michael McCandless in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1594062 ]

        LUCENE-5668: fix ob1 in TieredMergePolicy

        Show
        ASF subversion and git services added a comment - Commit 1594062 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1594062 ] LUCENE-5668 : fix ob1 in TieredMergePolicy
        Hide
        ASF subversion and git services added a comment -

        Commit 1594065 from Michael McCandless in branch 'dev/branches/lucene_solr_4_8'
        [ https://svn.apache.org/r1594065 ]

        LUCENE-5668: fix ob1 in TieredMergePolicy

        Show
        ASF subversion and git services added a comment - Commit 1594065 from Michael McCandless in branch 'dev/branches/lucene_solr_4_8' [ https://svn.apache.org/r1594065 ] LUCENE-5668 : fix ob1 in TieredMergePolicy
        Hide
        ASF subversion and git services added a comment -

        Commit 1594096 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1594096 ]

        LUCENE-5668: er, actually fix the bug

        Show
        ASF subversion and git services added a comment - Commit 1594096 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1594096 ] LUCENE-5668 : er, actually fix the bug
        Hide
        ASF subversion and git services added a comment -

        Commit 1594097 from Michael McCandless in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1594097 ]

        LUCENE-5668: er, actually fix the bug

        Show
        ASF subversion and git services added a comment - Commit 1594097 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1594097 ] LUCENE-5668 : er, actually fix the bug
        Hide
        ASF subversion and git services added a comment -

        Commit 1594098 from Michael McCandless in branch 'dev/branches/lucene_solr_4_8'
        [ https://svn.apache.org/r1594098 ]

        LUCENE-5668: er, actually fix the bug

        Show
        ASF subversion and git services added a comment - Commit 1594098 from Michael McCandless in branch 'dev/branches/lucene_solr_4_8' [ https://svn.apache.org/r1594098 ] LUCENE-5668 : er, actually fix the bug
        Hide
        ASF subversion and git services added a comment -

        Commit 1594107 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1594107 ]

        LUCENE-5668: fix the codec so segment sizes don't change on each flush

        Show
        ASF subversion and git services added a comment - Commit 1594107 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1594107 ] LUCENE-5668 : fix the codec so segment sizes don't change on each flush
        Hide
        ASF subversion and git services added a comment -

        Commit 1594108 from Michael McCandless in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1594108 ]

        LUCENE-5668: fix the codec so segment sizes don't change on each flush

        Show
        ASF subversion and git services added a comment - Commit 1594108 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1594108 ] LUCENE-5668 : fix the codec so segment sizes don't change on each flush
        Hide
        ASF subversion and git services added a comment -

        Commit 1594109 from Michael McCandless in branch 'dev/branches/lucene_solr_4_8'
        [ https://svn.apache.org/r1594109 ]

        LUCENE-5668: fix the codec so segment sizes don't change on each flush

        Show
        ASF subversion and git services added a comment - Commit 1594109 from Michael McCandless in branch 'dev/branches/lucene_solr_4_8' [ https://svn.apache.org/r1594109 ] LUCENE-5668 : fix the codec so segment sizes don't change on each flush

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development