Lucene - Core
  1. Lucene - Core
  2. LUCENE-5582

Remove IndexOutput.length and .setLength

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.8, Trunk
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Since we removed seeking from IndexOutput, you can just use
      .getFilePointer() to get the length. Also, nothing uses .setLength,
      so I think we should remove it too.

      1. LUCENE-5582.patch
        13 kB
        Michael McCandless

        Issue Links

          Activity

          Hide
          Michael McCandless added a comment -

          Patch.

          Show
          Michael McCandless added a comment - Patch.
          Hide
          ASF subversion and git services added a comment -

          Commit 1586743 from mikemccand@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1586743 ]

          LUCENE-5582: remove IndexOutput.length/setLength

          Show
          ASF subversion and git services added a comment - Commit 1586743 from mikemccand@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1586743 ] LUCENE-5582 : remove IndexOutput.length/setLength
          Hide
          ASF subversion and git services added a comment -

          Commit 1586747 from mikemccand@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1586747 ]

          LUCENE-5582: remove IndexOutput.length/setLength

          Show
          ASF subversion and git services added a comment - Commit 1586747 from mikemccand@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1586747 ] LUCENE-5582 : remove IndexOutput.length/setLength
          Hide
          ASF subversion and git services added a comment -

          Commit 1586748 from mikemccand@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1586748 ]

          LUCENE-5582: add changes entry

          Show
          ASF subversion and git services added a comment - Commit 1586748 from mikemccand@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1586748 ] LUCENE-5582 : add changes entry
          Hide
          Robert Muir added a comment -

          Can we backport the fixes in trunk to 4.x too? Currently only the deprecation was backported. I already tripped up on this with another unrelated patch.

          Show
          Robert Muir added a comment - Can we backport the fixes in trunk to 4.x too? Currently only the deprecation was backported. I already tripped up on this with another unrelated patch.
          Hide
          ASF subversion and git services added a comment -

          Commit 1588745 from rmuir@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1588745 ]

          LUCENE-5582: add workaround to 4.x for jenkins

          Show
          ASF subversion and git services added a comment - Commit 1588745 from rmuir@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1588745 ] LUCENE-5582 : add workaround to 4.x for jenkins
          Hide
          ASF subversion and git services added a comment -

          Commit 1588750 from rmuir@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1588750 ]

          LUCENE-5582: remove uses of length/setLength in tests and directpf

          Show
          ASF subversion and git services added a comment - Commit 1588750 from rmuir@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1588750 ] LUCENE-5582 : remove uses of length/setLength in tests and directpf
          Hide
          Robert Muir added a comment -

          was just a few places. now i can remove flush in these places, too

          Show
          Robert Muir added a comment - was just a few places. now i can remove flush in these places, too
          Hide
          ASF subversion and git services added a comment -

          Commit 1588752 from rmuir@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1588752 ]

          LUCENE-5582: remove workaround

          Show
          ASF subversion and git services added a comment - Commit 1588752 from rmuir@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1588752 ] LUCENE-5582 : remove workaround
          Hide
          Michael McCandless added a comment -

          Thanks!

          Show
          Michael McCandless added a comment - Thanks!
          Hide
          Uwe Schindler added a comment -

          Close issue after release of 4.8.0

          Show
          Uwe Schindler added a comment - Close issue after release of 4.8.0

            People

            • Assignee:
              Michael McCandless
              Reporter:
              Michael McCandless
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development