[LUCENE-5559] Argument validation for TokenFilters having numeric constructor parameter(s)

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.7
• Fix Version/s: 4.8, 6.0
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Ahmet Arslan
• Created: 28/Mar/14 18:28
• Updated: 28/Aug/22 14:03
• Resolved: 01/Apr/14 04:52

Description

Some TokenFilters have numeric arguments in their constructors. They should throw IllegalArgumentException for negative or meaningless values.

Here is some examples that demonstrates invalid/meaningless arguments :

 <filter class="solr.LimitTokenCountFilterFactory" maxTokenCount="-10" />

 <filter class="solr.LengthFilterFactory" min="-5" max="-1" />

 <filter class="solr.LimitTokenPositionFilterFactory" maxTokenPosition="-3" />