[LUCENE-5544] exceptions during IW.rollback can leak files and locks

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.7.1, 4.8, 6.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 21/Mar/14 04:03
• Updated: 28/Aug/22 14:03
• Resolved: 21/Mar/14 17:06

Description

Today, rollback() doesn't always succeed: if it does, it closes the writer nicely. otherwise, if it hits exception, it leaves you with a half-broken writer, still potentially holding file handles and write lock.

This is especially bad if you use Native locks, because you are kind of hosed, the static map prevents you from forcefully unlocking (e.g. IndexWriter.unlock) so you have no real course of action to try to recover.

If rollback() hits exception, it should still deliver the exception, but release things (e.g. like IOUtils.close).

Issue Links

• is related to: SOLR-6002 Fix a couple of ugly issues around SolrIndexWriter close and rollback as well as how SolrIndexWriter manages it's ref counted directory instance.