Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.8, 6.0
    • Component/s: core/store
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Since 3.0.x/3.6.x (see LUCENE-5541), Lucene has substantially removed
      its reliance on fileExists to the point where I think we can fully
      remove it now.

      Like the other iffy IO methods we've removed over time (touchFile,
      fileModified, seeking back during write, ...), File.exists is
      dangerous because a low level IO issue can cause it to return false
      when it should have returned true. The fewer IO operations we rely on
      the more reliable/portable Lucene is.

      1. LUCENE-5543.patch
        55 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Patch, I think it's ready.

        Show
        Michael McCandless added a comment - Patch, I think it's ready.
        Hide
        ASF subversion and git services added a comment -

        Commit 1580540 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1580540 ]

        LUCENE-5543 remove/deprecate Directory.fileExists

        Show
        ASF subversion and git services added a comment - Commit 1580540 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1580540 ] LUCENE-5543 remove/deprecate Directory.fileExists
        Hide
        ASF subversion and git services added a comment -

        Commit 1580557 from Michael McCandless in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1580557 ]

        LUCENE-5543 remove/deprecate Directory.fileExists

        Show
        ASF subversion and git services added a comment - Commit 1580557 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1580557 ] LUCENE-5543 remove/deprecate Directory.fileExists
        Hide
        ASF subversion and git services added a comment -

        Commit 1580707 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1580707 ]

        LUCENE-5543: Add allowReadingFilesStillOpenForWrite to MockDirectoryFactory and MockDirectoryWrapper and set it to true for cloud tests.

        Show
        ASF subversion and git services added a comment - Commit 1580707 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1580707 ] LUCENE-5543 : Add allowReadingFilesStillOpenForWrite to MockDirectoryFactory and MockDirectoryWrapper and set it to true for cloud tests.
        Hide
        ASF subversion and git services added a comment -

        Commit 1580709 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1580709 ]

        LUCENE-5543: Add allowReadingFilesStillOpenForWrite to MockDirectoryFactory and MockDirectoryWrapper and set it to true for cloud tests.

        Show
        ASF subversion and git services added a comment - Commit 1580709 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1580709 ] LUCENE-5543 : Add allowReadingFilesStillOpenForWrite to MockDirectoryFactory and MockDirectoryWrapper and set it to true for cloud tests.
        Hide
        Uwe Schindler added a comment -

        Close issue after release of 4.8.0

        Show
        Uwe Schindler added a comment - Close issue after release of 4.8.0

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development