Lucene - Core
  1. Lucene - Core
  2. LUCENE-5538

FastVectorHighlighter fails with booleans of phrases

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7.1, 4.8, 6.0
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      in some situations a query of (P1 OR PQ) returns no results, even though individually, both P1 or P2 by themselves will highlight correctly..

      1. LUCENE-5538_test.patch
        4 kB
        Robert Muir
      2. LUCENE-5538.patch
        11 kB
        Robert Muir
      3. LUCENE-5538.patch
        6 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -

        Here is a simple test. Seems to be related to the use of index-time synonyms.

        Show
        Robert Muir added a comment - Here is a simple test. Seems to be related to the use of index-time synonyms.
        Hide
        Robert Muir added a comment -

        Here's a patch I'm testing (all tests seem to pass, but I will see if i can add some better ones).

        FieldTermStack is ordered by position, but the current code doesn't really handle position increments of 0 (synonyms). In this case when we reach a dead-end (nextMap == null), we keep looking as long as the incoming position is the same until we find a match.

        Show
        Robert Muir added a comment - Here's a patch I'm testing (all tests seem to pass, but I will see if i can add some better ones). FieldTermStack is ordered by position, but the current code doesn't really handle position increments of 0 (synonyms). In this case when we reach a dead-end (nextMap == null), we keep looking as long as the incoming position is the same until we find a match.
        Hide
        Robert Muir added a comment -

        Here's a better patch. This should be correct for all crazy combinations. TermInfo gets a next pointer (circular list) for other infos at the same position.

        This allows the current stack pop/push algorithm to work without a bunch of additional complexity to "restore" synonyms.

        Show
        Robert Muir added a comment - Here's a better patch. This should be correct for all crazy combinations. TermInfo gets a next pointer (circular list) for other infos at the same position. This allows the current stack pop/push algorithm to work without a bunch of additional complexity to "restore" synonyms.
        Hide
        Adrien Grand added a comment -

        +1!

        Show
        Adrien Grand added a comment - +1!
        Hide
        ASF subversion and git services added a comment -

        Commit 1579255 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1579255 ]

        LUCENE-5538: FastVectorHighlighter fails with booleans of phrases

        Show
        ASF subversion and git services added a comment - Commit 1579255 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1579255 ] LUCENE-5538 : FastVectorHighlighter fails with booleans of phrases
        Hide
        ASF subversion and git services added a comment -

        Commit 1579264 from Robert Muir in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1579264 ]

        LUCENE-5538: FastVectorHighlighter fails with booleans of phrases

        Show
        ASF subversion and git services added a comment - Commit 1579264 from Robert Muir in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1579264 ] LUCENE-5538 : FastVectorHighlighter fails with booleans of phrases
        Hide
        ASF subversion and git services added a comment -

        Commit 1579269 from Robert Muir in branch 'dev/branches/lucene_solr_4_7'
        [ https://svn.apache.org/r1579269 ]

        LUCENE-5538: FastVectorHighlighter fails with booleans of phrases

        Show
        ASF subversion and git services added a comment - Commit 1579269 from Robert Muir in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1579269 ] LUCENE-5538 : FastVectorHighlighter fails with booleans of phrases
        Hide
        Steve Rowe added a comment -

        Bulk close 4.7.1 issues

        Show
        Steve Rowe added a comment - Bulk close 4.7.1 issues

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development