Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.7
    • Fix Version/s: 4.7.1, 4.8, 6.0
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      DrillSideways.DrillSidewaysResult uses Facets when the query does not filter by a facet, but it uses MultiFacets when it does, and MultiFacets implementation is not complete.

      See: https://github.com/apache/lucene-solr/blob/0b0bc89932622f5bc2c4d74f978178b9ae15c700/lucene/facet/src/java/org/apache/lucene/facet/MultiFacets.java#L67

      See http://pastebin.com/5eDbTM2v

      This code works when DrillDownQuery.add is not called (when there is no facets selected), but it fails with an UnsupportedOperationException.

      Perhaps I'm not using Facets correctly, but I'm trying to figure it out to upgrade from 4.6.1 by my self as I could not find a documentation other than javadocs for facets.

      1. LUCENE-5525.patch
        7 kB
        Michael McCandless
      2. LUCENE-5525.patch
        3 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        I think we should just implement that method?

        In the meantime, as a workaround, if you know the specific dimensions you want to retrieve, you can just call MultiFacets.getTopChildren for each dimension?

        Show
        Michael McCandless added a comment - I think we should just implement that method? In the meantime, as a workaround, if you know the specific dimensions you want to retrieve, you can just call MultiFacets.getTopChildren for each dimension?
        Hide
        Jose Peleteiro added a comment -

        Thank you!

        Show
        Jose Peleteiro added a comment - Thank you!
        Hide
        Michael McCandless added a comment -

        Patch, I think it's ready.

        Show
        Michael McCandless added a comment - Patch, I think it's ready.
        Hide
        Shai Erera added a comment -

        Looks good, +1!

        Show
        Shai Erera added a comment - Looks good, +1!
        Hide
        Shai Erera added a comment -

        I reviewed MultiCategoryListsFacetsExample.java under lucene/demo – do you think it should use MultiFacets? And also exercise getAllDims()?

        Show
        Shai Erera added a comment - I reviewed MultiCategoryListsFacetsExample.java under lucene/demo – do you think it should use MultiFacets? And also exercise getAllDims()?
        Hide
        Michael McCandless added a comment -

        I reviewed MultiCategoryListsFacetsExample.java under lucene/demo – do you think it should use MultiFacets? And also exercise getAllDims()?

        I think MultiFacets usage there is a bit forced?

        But I did add a new testDrillSideways to SimpleFacetsExample, which uses getAllDims.

        Show
        Michael McCandless added a comment - I reviewed MultiCategoryListsFacetsExample.java under lucene/demo – do you think it should use MultiFacets? And also exercise getAllDims()? I think MultiFacets usage there is a bit forced? But I did add a new testDrillSideways to SimpleFacetsExample, which uses getAllDims.
        Hide
        Michael McCandless added a comment -

        New patch, I think it's ready.

        Show
        Michael McCandless added a comment - New patch, I think it's ready.
        Hide
        Shai Erera added a comment -

        Looks good!

        Show
        Shai Erera added a comment - Looks good!
        Hide
        ASF subversion and git services added a comment -

        Commit 1578042 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1578042 ]

        LUCENE-5525: implement MultiFacets.getAllDims

        Show
        ASF subversion and git services added a comment - Commit 1578042 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1578042 ] LUCENE-5525 : implement MultiFacets.getAllDims
        Hide
        ASF subversion and git services added a comment -

        Commit 1578043 from Michael McCandless in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1578043 ]

        LUCENE-5525: implement MultiFacets.getAllDims

        Show
        ASF subversion and git services added a comment - Commit 1578043 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1578043 ] LUCENE-5525 : implement MultiFacets.getAllDims
        Hide
        Michael McCandless added a comment -

        Reopen to backport to 4.7.x

        Show
        Michael McCandless added a comment - Reopen to backport to 4.7.x
        Hide
        ASF subversion and git services added a comment -

        Commit 1578530 from Michael McCandless in branch 'dev/branches/lucene_solr_4_7'
        [ https://svn.apache.org/r1578530 ]

        LUCENE-5525: backport to 4.7.x

        Show
        ASF subversion and git services added a comment - Commit 1578530 from Michael McCandless in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1578530 ] LUCENE-5525 : backport to 4.7.x
        Hide
        Steve Rowe added a comment -

        Bulk close 4.7.1 issues

        Show
        Steve Rowe added a comment - Bulk close 4.7.1 issues

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Jose Peleteiro
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development