Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5519

Make queueDepth enforcing optional in TopNSearcher

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.7
    • 4.8, 6.0
    • core/FSTs
    • None
    • New, Patch Available

    Description

      currently TopNSearcher enforces the maxQueueSize based on rejectedCount + topN. I have a usecase where I just simply don't know the exact limit and I am ok with a top N that is not 100% exact. Yet, if I don't specify the right upper limit for the queue size I get an assertion error when I run tests but the only workaround it to make the queue unbounded which looks odd while it would possibly work just fine. I think it's fair to add an option that just doesn't enforce the limit and if it shoudl be enforced we throw a real exception.

      Attachments

        1. LUCENE-5519.patch
          35 kB
          Simon Willnauer
        2. LUCENE-5519.patch
          30 kB
          Simon Willnauer
        3. LUCENE-5519.patch
          8 kB
          Simon Willnauer

        Activity

          People

            Unassigned Unassigned
            simonw Simon Willnauer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: