Lucene - Core
  1. Lucene - Core
  2. LUCENE-5516

Forward information that trigger a merge to MergeScheduler

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.7
    • Fix Version/s: 4.8, 6.0
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Today we pass information about the merge trigger to the merge policy. Yet, no matter if the MP finds a merge or not we call the MergeScheduler who runs & blocks even if we didn't find a merge. In some cases we don't even want this to happen but inside the MergeScheduler we have no choice to opt out since we don't know what triggered the merge. We should forward the infos we have to the MergeScheduler as well.

      1. LUCENE-5516.patch
        20 kB
        Simon Willnauer
      2. LUCENE-5516.patch
        19 kB
        Simon Willnauer

        Activity

        Hide
        Simon Willnauer added a comment -

        here is a patch

        Show
        Simon Willnauer added a comment - here is a patch
        Hide
        Michael McCandless added a comment -

        +1

        Maybe just fix the naming so it's either foundNewMerges or newMergesFound? I think I see both in IndexWriter.java.

        Show
        Michael McCandless added a comment - +1 Maybe just fix the naming so it's either foundNewMerges or newMergesFound? I think I see both in IndexWriter.java.
        Hide
        Simon Willnauer added a comment -

        here is an updated patch fixing the naming. Thanks for looking at it mike....

        Show
        Simon Willnauer added a comment - here is an updated patch fixing the naming. Thanks for looking at it mike....
        Hide
        Shay Banon added a comment -

        +1, this looks great!. Exactly the info we would love to have to better control merges.

        Show
        Shay Banon added a comment - +1, this looks great!. Exactly the info we would love to have to better control merges.
        Hide
        ASF subversion and git services added a comment -

        Commit 1576475 from Simon Willnauer in branch 'dev/trunk'
        [ https://svn.apache.org/r1576475 ]

        LUCENE-5516: Forward information that trigger a merge to MergeScheduler

        Show
        ASF subversion and git services added a comment - Commit 1576475 from Simon Willnauer in branch 'dev/trunk' [ https://svn.apache.org/r1576475 ] LUCENE-5516 : Forward information that trigger a merge to MergeScheduler
        Hide
        ASF subversion and git services added a comment -

        Commit 1576476 from Simon Willnauer in branch 'dev/trunk'
        [ https://svn.apache.org/r1576476 ]

        LUCENE-5516: Add missing file

        Show
        ASF subversion and git services added a comment - Commit 1576476 from Simon Willnauer in branch 'dev/trunk' [ https://svn.apache.org/r1576476 ] LUCENE-5516 : Add missing file
        Hide
        ASF subversion and git services added a comment -

        Commit 1576482 from Simon Willnauer in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1576482 ]

        LUCENE-5516: Forward information that trigger a merge to MergeScheduler

        Show
        ASF subversion and git services added a comment - Commit 1576482 from Simon Willnauer in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1576482 ] LUCENE-5516 : Forward information that trigger a merge to MergeScheduler
        Hide
        Uwe Schindler added a comment -

        Close issue after release of 4.8.0

        Show
        Uwe Schindler added a comment - Close issue after release of 4.8.0

          People

          • Assignee:
            Simon Willnauer
            Reporter:
            Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development