In this case no problem, but just as an FYI, if you have trunk/ and branch/, you always want to run the differ outside of both (this way the patch prefixes are the same: this one cant be applied by any patch tool).
I actually did that at first but for some reason I thought the resulting patch file was wrong! Next time I'll do it like that.
docs for Weight.scoresDocsOutOfOrder() should refer to bulkScorer() instead of scorer()
Oh yeah, I'll fix.
a TODO should be added for BooleanWeight.scoresDocsOutOfOrder
I fixed this and added a simple test, on the branch.
should FakeScorer really not take the real Weight anymore? I don't know how useful it is, but its wierd that its null, since the Collector actually sees this thing via setScorer: if its not going to be supported then i think it should override getWeight to explicitly throw UOE?
It seems weird returning a real Weight when everything else is fake, but I guess we can just leave it as it was (in BooleanQuery)? All the other FakeScorers seem to do the null Weight thing, but I agree if we do that we should just override getWeight to throw UOE.
what is the purpose of a LeapFrogBulkScorer? It seems to just use two in-order scorers, i dont understand its purpose. Is this supposed to be a code specialization?
It was there before, but I think it's just code specialization ... I'll just nuke it and let Weight.bulkScorer do the default impl.