Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.8, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I added a lot of tests and greatly refined this algorithm to match correct hunspell behavior. there were many bugs:

      • recursionLimit was a hack: this is actually specified by the dictionary to be twofold suffix + one prefix, or if COMPLEXPREFIXES is specified, twofold prefix + one suffix. This patch removes cursion limit
      • recursion didn't work correctly: it didnt validate multi-level continuation classes correctly.
      • add COMPLEXPREFIXES support.
      • probably other minor bugs fixed in the process.

      I validated all testing against hunspell

      1. LUCENE-5483.patch
        44 kB
        Robert Muir
      2. LUCENE-5483.patch
        38 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -

        added additional test for COMPLEXPREFIXES, fixed mark/reset for proper line numbers in error messages (needed for stuff like hungarian with tons of stuff before the SET), and i did a bunch of manual testing vs hunspell -m with various real dictionaries (no problems).

        This is ready to go.

        Show
        Robert Muir added a comment - added additional test for COMPLEXPREFIXES, fixed mark/reset for proper line numbers in error messages (needed for stuff like hungarian with tons of stuff before the SET), and i did a bunch of manual testing vs hunspell -m with various real dictionaries (no problems). This is ready to go.
        Hide
        ASF subversion and git services added a comment -

        Commit 1573248 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1573248 ]

        LUCENE-5483: fix hunspell inaccuracies

        Show
        ASF subversion and git services added a comment - Commit 1573248 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1573248 ] LUCENE-5483 : fix hunspell inaccuracies
        Hide
        Chris Male added a comment -

        +1

        Show
        Chris Male added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1573251 from Robert Muir in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1573251 ]

        LUCENE-5483: fix hunspell inaccuracies

        Show
        ASF subversion and git services added a comment - Commit 1573251 from Robert Muir in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1573251 ] LUCENE-5483 : fix hunspell inaccuracies
        Hide
        Uwe Schindler added a comment -

        Close issue after release of 4.8.0

        Show
        Uwe Schindler added a comment - Close issue after release of 4.8.0
        Hide
        ASF subversion and git services added a comment -

        Commit 1614388 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1614388 ]

        LUCENE-5483: IndexWriter now enforces max docs in one index

        Show
        ASF subversion and git services added a comment - Commit 1614388 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1614388 ] LUCENE-5483 : IndexWriter now enforces max docs in one index
        Hide
        Michael McCandless added a comment -

        Woops, that commit message was meant for LUCENE-5843 instead... I corrected the svn log.

        Show
        Michael McCandless added a comment - Woops, that commit message was meant for LUCENE-5843 instead... I corrected the svn log.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development