Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5477

add near-real-time suggest building to AnalyzingInfixSuggester

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.8, 6.0
        • Component/s: modules/spellchecker
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          Because this suggester impl. is just a Lucene index under-the-hood, it should be straightforward to enable near-real-time additions/removals of suggestions.

          1. Text File
            LUCENE-5477.patch
            38 kB
            Michael McCandless
          2. Text File
            LUCENE-5477.patch
            54 kB
            Michael McCandless

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            thetaphi Uwe Schindler added a comment -

            Close issue after release of 4.8.0

            Show
            thetaphi Uwe Schindler added a comment - Close issue after release of 4.8.0
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1573080 from Michael McCandless in branch 'dev/branches/lucene5376'
            [ https://svn.apache.org/r1573080 ]

            LUCENE-5376, LUCENE-5477: add near-real-time suggest updates when using AnalyzingInfixSuggester to Lucene demo server

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1573080 from Michael McCandless in branch 'dev/branches/lucene5376' [ https://svn.apache.org/r1573080 ] LUCENE-5376 , LUCENE-5477 : add near-real-time suggest updates when using AnalyzingInfixSuggester to Lucene demo server
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1572997 from Michael McCandless in branch 'dev/branches/branch_4x'
            [ https://svn.apache.org/r1572997 ]

            LUCENE-5477: add near-real-time add/update/refresh to AnalyzingInfixSuggester

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1572997 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1572997 ] LUCENE-5477 : add near-real-time add/update/refresh to AnalyzingInfixSuggester
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1572992 from Michael McCandless in branch 'dev/trunk'
            [ https://svn.apache.org/r1572992 ]

            LUCENE-5477: add near-real-time add/update/refresh to AnalyzingInfixSuggester

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1572992 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1572992 ] LUCENE-5477 : add near-real-time add/update/refresh to AnalyzingInfixSuggester
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            New patch, adding random test, which seems to be passing ... I think it's ready; I'll commit soon.

            Show
            mikemccand Michael McCandless added a comment - New patch, adding random test, which seems to be passing ... I think it's ready; I'll commit soon.
            Hide
            Permalink
            areek Areek Zillur added a comment -

            Wow, that looks awesome! Thanks for getting rid of the redundant casting of InputIterator too.

            Show
            areek Areek Zillur added a comment - Wow, that looks awesome! Thanks for getting rid of the redundant casting of InputIterator too.
            Hide
            Permalink
            rcmuir Robert Muir added a comment -

            this looks great!

            Show
            rcmuir Robert Muir added a comment - this looks great!
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            Initial patch, with new add/update/refresh methods added to AnalyzingInfixSuggester.

            I added a "testBasicNRT" and it seems to pass, but I still need to add a randomized test.

            I think the approach will work well: I'm just using SortingMergePolicy and EarlyTerminatingSortingCollector, and I switched to SearcherManager to pull the current searcher.

            Show
            mikemccand Michael McCandless added a comment - Initial patch, with new add/update/refresh methods added to AnalyzingInfixSuggester. I added a "testBasicNRT" and it seems to pass, but I still need to add a randomized test. I think the approach will work well: I'm just using SortingMergePolicy and EarlyTerminatingSortingCollector, and I switched to SearcherManager to pull the current searcher.

              People

              • Assignee:
                mikemccand Michael McCandless
                Reporter:
                mikemccand Michael McCandless
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development