Lucene - Core
  1. Lucene - Core
  2. LUCENE-5420

'ant get-maven-poms' should support custom version formats

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      LUCENE-5217 changed the way ant get-maven-poms works, so that dependencies are pulled from the Ant build, instead of being hard-coded in the POM templates. To parse the versions from internal module dependencies, the new internal Ant task GetMavenDependenciesTask uses a regex that expects a dotted/slashed/underscored numeric + optional -SNAPSHOT version format. As a result, non-conforming versions trigger a build failure - see the lucene-dev mailing list thread "maven build issues with non-numeric custom version": <http://mail-archives.apache.org/mod_mbox/lucene-dev/201401.mbox/%3cCAF=Pa5-0sXE9Su1PgF5M+F0T+g3Q=fetWgXDh5Ry1ab3ZRhquQ@mail.gmail.com%3e>

      This is a regression, since previously, custom version strings worked properly, e.g. ant -Dversion=my-custom-version get-maven-poms.

        Issue Links

          Activity

          Hide
          Steve Rowe added a comment -

          Patch fixing the issue by replacing the overly restrictive expected version format with the actual project version in the internal-deps regex. Also updates README.maven.

          Show
          Steve Rowe added a comment - Patch fixing the issue by replacing the overly restrictive expected version format with the actual project version in the internal-deps regex. Also updates README.maven.
          Hide
          Ryan McKinley added a comment -

          thanks steve – looks good

          Show
          Ryan McKinley added a comment - thanks steve – looks good
          Hide
          ASF subversion and git services added a comment -

          Commit 1562530 from Steve Rowe in branch 'dev/trunk'
          [ https://svn.apache.org/r1562530 ]

          LUCENE-5420: 'ant get-maven-poms' should support custom version formats

          Show
          ASF subversion and git services added a comment - Commit 1562530 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1562530 ] LUCENE-5420 : 'ant get-maven-poms' should support custom version formats
          Hide
          ASF subversion and git services added a comment -

          Commit 1562533 from Steve Rowe in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1562533 ]

          LUCENE-5420: 'ant get-maven-poms' should support custom version formats (merged trunk r1562530)

          Show
          ASF subversion and git services added a comment - Commit 1562533 from Steve Rowe in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1562533 ] LUCENE-5420 : 'ant get-maven-poms' should support custom version formats (merged trunk r1562530)
          Hide
          Steve Rowe added a comment -

          Ryan, thanks for reporting and testing.

          Committed to trunk and branch_4x.

          Show
          Steve Rowe added a comment - Ryan, thanks for reporting and testing. Committed to trunk and branch_4x.
          Hide
          ASF subversion and git services added a comment -

          Commit 1562554 from Steve Rowe in branch 'dev/trunk'
          [ https://svn.apache.org/r1562554 ]

          LUCENE-5420: stop re-compiling the internal module dependency regex for every dependency

          Show
          ASF subversion and git services added a comment - Commit 1562554 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1562554 ] LUCENE-5420 : stop re-compiling the internal module dependency regex for every dependency
          Hide
          ASF subversion and git services added a comment -

          Commit 1562556 from Steve Rowe in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1562556 ]

          LUCENE-5420: stop re-compiling the internal module dependency regex for every dependency (merged trunk r1562554)

          Show
          ASF subversion and git services added a comment - Commit 1562556 from Steve Rowe in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1562556 ] LUCENE-5420 : stop re-compiling the internal module dependency regex for every dependency (merged trunk r1562554)

            People

            • Assignee:
              Steve Rowe
              Reporter:
              Steve Rowe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development