Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Followup from LUCENE-5377:

      the root cause of all the hair there is because SI.files (set of files used by the segment), must be rewritten in addIndexes because its invalidated by the change of segment name.

      alternatively we could just not store this stuff, and strip the segment names. This is how CFS deals with this issue already.

      I think we can do this in a backwards compatible way too: for old codecs, the readers could be changed to simply strip internally (e.g. ignore the "extra" information they wrote) ?

        Activity

        Hide
        anshumg Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        anshumg Anshum Gupta added a comment - Bulk close after 5.0 release.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1627943 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1627943 ]

        LUCENE-5969, LUCENE-5412: add more infos/metadata safety

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1627943 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1627943 ] LUCENE-5969 , LUCENE-5412 : add more infos/metadata safety
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1627941 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1627941 ]

        LUCENE-5969, LUCENE-5412: add more infos/metadata safety

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1627941 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1627941 ] LUCENE-5969 , LUCENE-5412 : add more infos/metadata safety
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1627535 from Robert Muir in branch 'dev/branches/lucene5969'
        [ https://svn.apache.org/r1627535 ]

        LUCENE-5969, LUCENE-5412: make .si immutable again, and make ancient writers read-only

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1627535 from Robert Muir in branch 'dev/branches/lucene5969' [ https://svn.apache.org/r1627535 ] LUCENE-5969 , LUCENE-5412 : make .si immutable again, and make ancient writers read-only
        Hide
        rcmuir Robert Muir added a comment -

        Exactly, something like that: I dont think we should change our high-level API?
        SI.files should return the set of actual filenames as it does now.

        This would just be a change to the codec API, to e.g. strip the stuff we pass to the SI Writer or whatever.
        And the old codecs would strip what they read (as they wrote the unnecessary additional stuff).
        And we remove the call to SIWriter in addIndexes

        Show
        rcmuir Robert Muir added a comment - Exactly, something like that: I dont think we should change our high-level API? SI.files should return the set of actual filenames as it does now. This would just be a change to the codec API, to e.g. strip the stuff we pass to the SI Writer or whatever. And the old codecs would strip what they read (as they wrote the unnecessary additional stuff). And we remove the call to SIWriter in addIndexes
        Hide
        shaie Shai Erera added a comment -

        Could we change SegmentInfo.setFiles() to strip the segment name maybe? Just thinking of fewer places in the code to touch.

        Show
        shaie Shai Erera added a comment - Could we change SegmentInfo.setFiles() to strip the segment name maybe? Just thinking of fewer places in the code to touch.

          People

          • Assignee:
            Unassigned
            Reporter:
            rcmuir Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development