[LUCENE-5364] Review usages of hard-coded Version constants

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.7, 6.0
• Fix Version/s: 4.7, 6.0
• Component/s: core/other
• Lucene Fields: New, Patch Available
• Assignee: Steven Rowe
• Reporter: Steven Rowe
• Created: 07/Dec/13 00:54
• Updated: 28/Aug/22 13:57
• Resolved: 09/Dec/13 23:57

Description

There are some hard-coded Version.LUCENE_XY constants used in various places. Some of these are intentional and appropriate:

• in deprecated code, e.g. ArabicLetterTokenizer, deprecated in 3.1, uses Version.LUCENE_31
• to make behavior version-dependent (e.g. StandardTokenizer and other analysis components)
• to test different behavior at different points in history (e.g. TestStopFilter to test position increments)

But should hard-coded constants be used elsewhere?

For those that should remain, and need to be updated with each release, there should be an easy way to find them.