Lucene - Core
  1. Lucene - Core
  2. LUCENE-5320

Create SearcherTaxonomyManager over Directory

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7, 6.0
    • Component/s: modules/facet
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      SearcherTaxonomyManager now only allows working in NRT mode. It could be useful to have an STM which allows reopening a SearcherAndTaxonomy pair over Directories, e.g. for replication. The problem is that if the thread that calls maybeRefresh() is not the one that does the commit(), it could lead to a pair that is not synchronized.

      Perhaps at first we could have a simple version that works under some assumptions, i.e. that the app does the commit + reopen in the same thread in that order, so that it can be used by such apps + when replicating the indexes, and later we can figure out how to generalize it to work even if commit + reopen are done by separate threads/JVMs.

      I'll see if SearcherTaxonomyManager can be extended to support it, or a new STM is required.

        Activity

        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Shai Erera added a comment -

        Patch adds a ctor to SearcherTaxoManager and tests.

        Show
        Shai Erera added a comment - Patch adds a ctor to SearcherTaxoManager and tests.
        Hide
        Michael McCandless added a comment -

        +1, thanks Shai!

        Show
        Michael McCandless added a comment - +1, thanks Shai!
        Hide
        ASF subversion and git services added a comment -

        Commit 1562806 from Shai Erera in branch 'dev/trunk'
        [ https://svn.apache.org/r1562806 ]

        LUCENE-5320: Add SearcherTaxonomyManager over Directory

        Show
        ASF subversion and git services added a comment - Commit 1562806 from Shai Erera in branch 'dev/trunk' [ https://svn.apache.org/r1562806 ] LUCENE-5320 : Add SearcherTaxonomyManager over Directory
        Hide
        ASF subversion and git services added a comment -

        Commit 1562808 from Shai Erera in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1562808 ]

        LUCENE-5320: Add SearcherTaxonomyManager over Directory

        Show
        ASF subversion and git services added a comment - Commit 1562808 from Shai Erera in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1562808 ] LUCENE-5320 : Add SearcherTaxonomyManager over Directory
        Hide
        Shai Erera added a comment -

        Committed to trunk and 4x.

        Show
        Shai Erera added a comment - Committed to trunk and 4x.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development