Lucene - Core
  1. Lucene - Core
  2. LUCENE-5306

Add CompositeReader Support to DocumentExpressionDictionary

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6, 5.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Currently the DocumentExpressionDictionary does not have support for CompositeReader. It would be nice to add that support.

      1. LUCENE-5306.patch
        7 kB
        Areek Zillur
      2. LUCENE-5306.patch
        7 kB
        Areek Zillur

        Activity

        Areek Zillur created issue -
        Hide
        Areek Zillur added a comment -

        Patch uploaded:

        • added support for CompositeReader
        • tested with ant test -Dtestcase=DocumentExpressionDictionaryTest -Dtests.method=testBasic -Dtests.seed=42EFE66B86DB4740 -Dtests.slow=true -Dtests.locale=es_BO -Dtests.timezone=US/Central -Dtests.file.encoding=UTF-8 https://issues.apache.org/jira/browse/LUCENE-5305
        Show
        Areek Zillur added a comment - Patch uploaded: added support for CompositeReader tested with ant test -Dtestcase=DocumentExpressionDictionaryTest -Dtests.method=testBasic -Dtests.seed=42EFE66B86DB4740 -Dtests.slow=true -Dtests.locale=es_BO -Dtests.timezone=US/Central -Dtests.file.encoding=UTF-8 https://issues.apache.org/jira/browse/LUCENE-5305
        Areek Zillur made changes -
        Field Original Value New Value
        Attachment LUCENE-5306.patch [ 12610148 ]
        Hide
        Areek Zillur added a comment -

        Patch (minor change):

        • additional check to ensure that the leave size of the reader is not zero.
        Show
        Areek Zillur added a comment - Patch (minor change): additional check to ensure that the leave size of the reader is not zero.
        Areek Zillur made changes -
        Attachment LUCENE-5306.patch [ 12610769 ]
        Hide
        Michael McCandless added a comment -

        Thanks Areek, the patch looks great; I'll commit shortly!

        Show
        Michael McCandless added a comment - Thanks Areek, the patch looks great; I'll commit shortly!
        Hide
        ASF subversion and git services added a comment -

        Commit 1536826 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1536826 ]

        LUCENE-5306: DocumentExpressionDictionary now accepts composite readers

        Show
        ASF subversion and git services added a comment - Commit 1536826 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1536826 ] LUCENE-5306 : DocumentExpressionDictionary now accepts composite readers
        Hide
        ASF subversion and git services added a comment -

        Commit 1536827 from Michael McCandless in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1536827 ]

        LUCENE-5306: DocumentExpressionDictionary now accepts composite readers

        Show
        ASF subversion and git services added a comment - Commit 1536827 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1536827 ] LUCENE-5306 : DocumentExpressionDictionary now accepts composite readers
        Michael McCandless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.6 [ 12324999 ]
        Fix Version/s 5.0 [ 12321663 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Areek Zillur
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development