Lucene - Core
  1. Lucene - Core
  2. LUCENE-5304

SingletonSortedSetDocValues should allow for getting back the wrapped instance

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This idea was mentioned by Robert on LUCENE-5300

      Some codecs or FieldCache impls use SingletonSortedSetDocValues when a field which is supposed to be multi-valued is actually single-valued. By having a getter on this class to get back the wrapped SortedDocValues instance, we could add more specialization (which often already exists, eg. Solr's DocValuesFacets already have a specialized impl for SortedDocValues).

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch that exposes the SortedDocValues instance in SingletonSortedSetDocValues and makes Solr's DocValuesFacets specialize accumulation when a SortedSetDocValues instance extends SingletonSortedSetDocValues.

        Show
        Adrien Grand added a comment - Here is a patch that exposes the SortedDocValues instance in SingletonSortedSetDocValues and makes Solr's DocValuesFacets specialize accumulation when a SortedSetDocValues instance extends SingletonSortedSetDocValues.
        Hide
        Robert Muir added a comment -

        +1, thats exactly what I had in mind.

        Show
        Robert Muir added a comment - +1, thats exactly what I had in mind.
        Hide
        ASF subversion and git services added a comment -

        Commit 1535382 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1535382 ]

        LUCENE-5304: SingletonSortedSetDocValues can now return the wrapped SortedDocValues

        Show
        ASF subversion and git services added a comment - Commit 1535382 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1535382 ] LUCENE-5304 : SingletonSortedSetDocValues can now return the wrapped SortedDocValues
        Hide
        ASF subversion and git services added a comment -

        Commit 1535383 from Adrien Grand in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1535383 ]

        LUCENE-5304: SingletonSortedSetDocValues can now return the wrapped SortedDocValues

        Show
        ASF subversion and git services added a comment - Commit 1535383 from Adrien Grand in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1535383 ] LUCENE-5304 : SingletonSortedSetDocValues can now return the wrapped SortedDocValues
        Hide
        Adrien Grand added a comment -

        Committed. Thanks Robert for the review!

        Show
        Adrien Grand added a comment - Committed. Thanks Robert for the review!

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development