Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6, 5.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      StemmerOverrideFilter is configured with an FST-based map that you can build at construction time from a list of entries. Building this FST offline and loading it directly as a bytestream makes construction a lot quicker, but you can't do that conveniently at the moment as all the methods of StemmerOverrideMap are package-private.

      1. LUCENE-5302.patch
        2 kB
        Alan Woodward

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1536859 from Alan Woodward in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1536859 ]

        LUCENE-5302: Make StemmerOverrideMap's methods public

        Show
        ASF subversion and git services added a comment - Commit 1536859 from Alan Woodward in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1536859 ] LUCENE-5302 : Make StemmerOverrideMap's methods public
        Hide
        ASF subversion and git services added a comment -

        Commit 1536858 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1536858 ]

        LUCENE-5302: Make StemmerOverrideMap's methods public

        Show
        ASF subversion and git services added a comment - Commit 1536858 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1536858 ] LUCENE-5302 : Make StemmerOverrideMap's methods public
        Hide
        Robert Muir added a comment -

        The @link was broken before, javadocs were just never generated because it only had package visibility.

        I think in this case the @link just has to be qualified as FST.Arc/FST.BytesReader or fully-qualify or whatever.

        Show
        Robert Muir added a comment - The @link was broken before, javadocs were just never generated because it only had package visibility. I think in this case the @link just has to be qualified as FST.Arc/FST.BytesReader or fully-qualify or whatever.
        Hide
        Alan Woodward added a comment -

        Hm, this patch fails ant precommit with a javadocs warning:

        lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/StemmerOverrideFilter.java:111: warning - Tag @link: can't find get(char[], int, Arc, BytesReader) in org.apache.lucene.analysis.miscellaneous.StemmerOverrideFilter.StemmerOverrideMap

        ...even though that method's javadoc is definitely there. Maybe because it's not defining the generic parameter on Arc? Anybody have any ideas, apart from changing the javadoc from a link var to a code var?

        Show
        Alan Woodward added a comment - Hm, this patch fails ant precommit with a javadocs warning: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/StemmerOverrideFilter.java:111: warning - Tag @link: can't find get(char[], int, Arc, BytesReader) in org.apache.lucene.analysis.miscellaneous.StemmerOverrideFilter.StemmerOverrideMap ...even though that method's javadoc is definitely there. Maybe because it's not defining the generic parameter on Arc? Anybody have any ideas, apart from changing the javadoc from a link var to a code var?
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1

          People

          • Assignee:
            Unassigned
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development