Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      While working on LUCENE-5268, I realized we have hasPositions/Offsets/Payloads methods in Terms but not hasFreqs ...

      1. LUCENE-5270.patch
        17 kB
        Michael McCandless
      2. LUCENE-5270.patch
        16 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Patch.

        Show
        Michael McCandless added a comment - Patch.
        Hide
        Robert Muir added a comment -

        looks great. are there any other checks we can do? like if hasFreqs = false, then sumTotalTermFreq should be -1 (and also totalTermFreq for each term). Otherwise the codec is lying!

        Show
        Robert Muir added a comment - looks great. are there any other checks we can do? like if hasFreqs = false, then sumTotalTermFreq should be -1 (and also totalTermFreq for each term). Otherwise the codec is lying!
        Hide
        Michael McCandless added a comment -

        Good idea, I'll add those two checks!

        Show
        Michael McCandless added a comment - Good idea, I'll add those two checks!
        Hide
        Robert Muir added a comment -

        We also return 1 for freq() when hasFreqs is false. If something else is returned its wrong.

        Its only undefined when you explicitly supply FLAG_NONE.

        Show
        Robert Muir added a comment - We also return 1 for freq() when hasFreqs is false. If something else is returned its wrong. Its only undefined when you explicitly supply FLAG_NONE.
        Hide
        Michael McCandless added a comment -

        New patch folding in Rob's ideas ... I think it's ready.

        Show
        Michael McCandless added a comment - New patch folding in Rob's ideas ... I think it's ready.
        Hide
        Robert Muir added a comment -

        Looks great, thanks!

        Show
        Robert Muir added a comment - Looks great, thanks!
        Hide
        ASF subversion and git services added a comment -

        Commit 1531005 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1531005 ]

        LUCENE-5270: add Terms.hasFreqs

        Show
        ASF subversion and git services added a comment - Commit 1531005 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1531005 ] LUCENE-5270 : add Terms.hasFreqs
        Hide
        ASF subversion and git services added a comment -

        Commit 1531011 from Michael McCandless in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1531011 ]

        LUCENE-5270: add Terms.hasFreqs

        Show
        ASF subversion and git services added a comment - Commit 1531011 from Michael McCandless in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1531011 ] LUCENE-5270 : add Terms.hasFreqs

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development