Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5229

remove Collector specializations

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      There are too many collector specializations (i think 16 or 18?) and too many crazy defaults like returning NaN scores to the user by default in indexsearcher.

      this confuses hotspot (I will ignore any benchmarks posted here where only one type of sort is running thru the JVM, thats unrealistic), and confuses users with stuff like NaN scores coming back by default.

      I have two concerete suggestions:

      • nuke doMaxScores. its implicit from doScores. This is just over the top. This should also halve the collectors.
      • change doScores to true by default in indexsearcher. since shai was confused by the NaNs by default, and he added this stuff to lucene, that says everything about how wrong this default is. Someone who does understand what it does can simply pass false.

        Attachments

        There are no Sub-Tasks for this issue.

          Activity

            People

            • Assignee:
              rcmuir Robert Muir
              Reporter:
              rcmuir Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: