Lucene - Core
  1. Lucene - Core
  2. LUCENE-5213

Use <groovy/> instead <script/> ant task

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6, 5.0
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      We currently use the <script/> task to execute groovy script while building (SVN working copy tests, determining javadocs URL,...), which works perfectly fine.

      The backside is that the groovy classpath is passed as separate classpath to ANT every time a <script/> task is executed. This leads to the problem that we get the usual ANT permgen problems, especially when we execute such tasks on sub.modules (we currently don't do this).

      This is one reason why I did not yet port over the "svnversion" calls to svnkit, because its executed on every module. The license checker may have the same problem, once I port it over to be a simple groovy macro (see LUCENE-5210).

      This patch uses the <groovy/> taskdef. The taskdef is only loaded once and can be inherited to subants.

      There is currently one task/macro that does not use the <groovy/> task: pegdown, because its implemented as a <scriptfilter/>: It is used to filter the markdown and convert to HTML when copying the main web page. There is no replacement with groovy's taskdef unless I refactor it to not be a <filter/> inside a <copy/> task.

      1. LUCENE-5213.patch
        4 kB
        Uwe Schindler

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1523215 from Uwe Schindler in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1523215 ]

        Merged revision(s) 1523214 from lucene/dev/trunk:
        LUCENE-5213: Use <groovy/> instead <script/> ant task

        Show
        ASF subversion and git services added a comment - Commit 1523215 from Uwe Schindler in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1523215 ] Merged revision(s) 1523214 from lucene/dev/trunk: LUCENE-5213 : Use <groovy/> instead <script/> ant task
        Hide
        ASF subversion and git services added a comment -

        Commit 1523214 from Uwe Schindler in branch 'dev/trunk'
        [ https://svn.apache.org/r1523214 ]

        LUCENE-5213: Use <groovy/> instead <script/> ant task

        Show
        ASF subversion and git services added a comment - Commit 1523214 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1523214 ] LUCENE-5213 : Use <groovy/> instead <script/> ant task
        Hide
        Uwe Schindler added a comment -

        I will commit and resolve this soon.

        Show
        Uwe Schindler added a comment - I will commit and resolve this soon.
        Hide
        Uwe Schindler added a comment -

        Simple patch.

        Show
        Uwe Schindler added a comment - Simple patch.

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development