Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5199

Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat used per-field

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Reopened
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.9, 6.0
    • Component/s: general/test
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      On LUCENE-5178 Han reported the following test failure:

      [junit4] FAILURE 0.27s | TestRangeAccumulator.testMissingValues <<<
         [junit4]    > Throwable #1: org.junit.ComparisonFailure: expected:<...(0)
         [junit4]    >   less than 10 ([8)
         [junit4]    >   less than or equal to 10 (]8)
         [junit4]    >   over 90 (8)
         [junit4]    >   9...> but was:<...(0)
         [junit4]    >   less than 10 ([28)
         [junit4]    >   less than or equal to 10 (2]8)
         [junit4]    >   over 90 (8)
         [junit4]    >   9...>
         [junit4]    > 	at __randomizedtesting.SeedInfo.seed([815B6AA86D05329C:EBC638EE498F066D]:0)
         [junit4]    > 	at org.apache.lucene.facet.range.TestRangeAccumulator.testMissingValues(TestRangeAccumulator.java:670)
         [junit4]    > 	at java.lang.Thread.run(Thread.java:722)
      

      which can be reproduced with

      tcase=TestRangeAccumulator -Dtests.method=testMissingValues -Dtests.seed=815B6AA86D05329C -Dtests.slow=true -Dtests.postingsformat=Lucene41 -Dtests.locale=ca -Dtests.timezone=Australia/Currie -Dtests.file.encoding=UTF-8
      

      It seems that the Codec that is picked is a Lucene45Codec with Lucene42DVFormat, which does not support docsWithFields for numericDV. We should improve LTC.defaultCodecSupportsDocsWithField to take a list of fields and check that the actual DVF used for each field supports it.

        Attachments

        1. LUCENE-5199.patch
          10 kB
          Robert Muir
        2. LUENE-5199.patch
          9 kB
          Shai Erera

          Activity

            People

            • Assignee:
              shaie Shai Erera
              Reporter:
              shaie Shai Erera
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: