Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, Trunk
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      I think it's useful if we have a top-level jar-src which generates source jars for all modules. One can basically do that by iterating through the directories and calling 'ant jar-src' already, so this is just a convenient way to do it. Will attach a patch shortly.

      1. LUCENE-5193.patch
        1 kB
        Shai Erera
      2. LUCENE-5193.patch
        1 kB
        Shai Erera
      3. LUCENE-5193.patch
        3 kB
        Steve Rowe

        Activity

        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close
        Hide
        Shai Erera added a comment -

        Steve, I guess I got to it before you . Committed to trunk and 4x.

        Show
        Shai Erera added a comment - Steve, I guess I got to it before you . Committed to trunk and 4x.
        Hide
        ASF subversion and git services added a comment -

        Commit 1518973 from Shai Erera in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1518973 ]

        LUCENE-5193: add jar-src to build.xml

        Show
        ASF subversion and git services added a comment - Commit 1518973 from Shai Erera in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1518973 ] LUCENE-5193 : add jar-src to build.xml
        Hide
        ASF subversion and git services added a comment -

        Commit 1518972 from Shai Erera in branch 'dev/trunk'
        [ https://svn.apache.org/r1518972 ]

        LUCENE-5193: add jar-src to build.xml

        Show
        ASF subversion and git services added a comment - Commit 1518972 from Shai Erera in branch 'dev/trunk' [ https://svn.apache.org/r1518972 ] LUCENE-5193 : add jar-src to build.xml
        Hide
        Shai Erera added a comment -

        Looks good Steve. Feel free to commit. I'm not sure I'll be able to today.

        Show
        Shai Erera added a comment - Looks good Steve. Feel free to commit. I'm not sure I'll be able to today.
        Hide
        Uwe Schindler added a comment -

        Thanks, looks good! Especially as the resources are now in the source JAR, which is done by the maven archiver plugin, too.

        Thanks also for adding the info text on top-level build, so ant prints it in the usage help.

        Show
        Uwe Schindler added a comment - Thanks, looks good! Especially as the resources are now in the source JAR, which is done by the maven archiver plugin, too. Thanks also for adding the info text on top-level build, so ant prints it in the usage help.
        Hide
        Steve Rowe added a comment -

        This patch incorporates Shai's Lucene patch, and adds Solr and top-level jar-src targets.

        I also took the opportunity to fix up Solr's jar-src specialization (needed for Solr-specific manifest entries) to be like Lucene's: the ${build.dir} is created, and the module's src/resources/** are included (only solr-uima and solr-langid have these at this point).

        I think it's ready to go - if you like, Shai, I can commit.

        Show
        Steve Rowe added a comment - This patch incorporates Shai's Lucene patch, and adds Solr and top-level jar-src targets. I also took the opportunity to fix up Solr's jar-src specialization (needed for Solr-specific manifest entries) to be like Lucene's: the ${build.dir } is created, and the module's src/resources/** are included (only solr-uima and solr-langid have these at this point). I think it's ready to go - if you like, Shai, I can commit.
        Hide
        Steve Rowe added a comment -

        +1

        I was worried that lucene-codecs src jar wouldn't be built – in my mind it's in the same category as core and test-framework: an internal module – but it's pulled in by the modules-crawl macro, which runs over all sub-directories with build.xml except build/, core/, test-framework/, and tools/.

        I'll make another patch for Solr and the top-level build.xml.

        Show
        Steve Rowe added a comment - +1 I was worried that lucene-codecs src jar wouldn't be built – in my mind it's in the same category as core and test-framework: an internal module – but it's pulled in by the modules-crawl macro, which runs over all sub-directories with build.xml except build/ , core/ , test-framework/ , and tools/ . I'll make another patch for Solr and the top-level build.xml .
        Hide
        Shai Erera added a comment -

        Previous patch did not jar-src core and test-framework.

        Show
        Shai Erera added a comment - Previous patch did not jar-src core and test-framework.
        Hide
        Shai Erera added a comment -

        If there are no objections, I'll commit it later today.

        Show
        Shai Erera added a comment - If there are no objections, I'll commit it later today.
        Hide
        Shai Erera added a comment -

        Simple patch for Lucene modules only, since they already support jar-src.

        Show
        Shai Erera added a comment - Simple patch for Lucene modules only, since they already support jar-src.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development