Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, Trunk
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      There are a couple of use cases I can think of where being able to get the underlying filter out of CachingWrapperFilter would be useful:
      1. You might want to introspect the filter to figure out what's in it (the use case we hit.)
      2. You might want to serialise the filter since Lucene no longer supports that itself.

      We currently work around this by subclassing, keeping another copy of the underlying filter reference and implementing a trivial getter, which is an easy workaround, but the trap is that a junior developer could unknowingly create a CachingWrapperFilter without knowing that the BetterCachingWrapperFilter exists, introducing a filter which cannot be introspected.

        Activity

        Hide
        Adrien Grand added a comment -

        This sounds good to me, would you like to write a patch?

        Show
        Adrien Grand added a comment - This sounds good to me, would you like to write a patch?
        Hide
        Trejkaz added a comment -

        Since it's pretty trivial.

        Show
        Trejkaz added a comment - Since it's pretty trivial.
        Hide
        ASF subversion and git services added a comment -

        Commit 1516773 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1516773 ]

        LUCENE-5186: Added CachingWrapperFilter.getFilter.

        Show
        ASF subversion and git services added a comment - Commit 1516773 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1516773 ] LUCENE-5186 : Added CachingWrapperFilter.getFilter.
        Hide
        ASF subversion and git services added a comment -

        Commit 1516774 from Adrien Grand in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1516774 ]

        LUCENE-5186: Added CachingWrapperFilter.getFilter.

        Show
        ASF subversion and git services added a comment - Commit 1516774 from Adrien Grand in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1516774 ] LUCENE-5186 : Added CachingWrapperFilter.getFilter.
        Hide
        Adrien Grand added a comment -

        Committed, thanks!

        Show
        Adrien Grand added a comment - Committed, thanks!
        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Trejkaz
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development