Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, Trunk
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Some current inconsistencies:

      • Binary/SortedDocValues.EMPTY_BYTES should be removed (BytesRef.EMPTY_BYTES should be used in its place): FieldCache.getDocsWithField should be used to determine missing. Thats fine if FC wants to "back" its Bits by some special placeholder value, but thats its impl detail not part of the API.
      • Sorting comparator of Binary should either be removed (is this REALLY useful?) or should support missingValue(): and it should support this for SortedDocValues in any case: solr does it, but lucene wont allow it accept for numerics?!

        Activity

        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Robert Muir added a comment -

        Here is a patch removing the EMPTY_BYTES. I dont care about BINARY at all, but this part of the API is bogus and must be removed.

        Show
        Robert Muir added a comment - Here is a patch removing the EMPTY_BYTES. I dont care about BINARY at all, but this part of the API is bogus and must be removed.
        Hide
        Michael McCandless added a comment -

        +1, patch looks good!

        Show
        Michael McCandless added a comment - +1, patch looks good!
        Hide
        Jack Krupansky added a comment -

        What's the Fix Version here? 4.5 as well as 5.0?

        Is there any backcompat issue with a 4.4 index that has Binary.EmptyBytes?

        Show
        Jack Krupansky added a comment - What's the Fix Version here? 4.5 as well as 5.0? Is there any backcompat issue with a 4.4 index that has Binary.EmptyBytes?
        Hide
        Adrien Grand added a comment -

        Patch looks good to me too. Can we just replace the occurrences of docsWithField.get(doc) == false with !docsWithField.get(doc)?

        Show
        Adrien Grand added a comment - Patch looks good to me too. Can we just replace the occurrences of docsWithField.get(doc) == false with !docsWithField.get(doc) ?
        Hide
        Robert Muir added a comment -

        Thats intentional: when there is a complex boolean expression, i do this on purpose to make it more readable and intent and precedence clear.

        I dont see a benefit of using ! here, it only makes code more difficult to read. I generally avoid it entirely these days.

        Show
        Robert Muir added a comment - Thats intentional: when there is a complex boolean expression, i do this on purpose to make it more readable and intent and precedence clear. I dont see a benefit of using ! here, it only makes code more difficult to read. I generally avoid it entirely these days.
        Hide
        Michael McCandless added a comment -

        I rather like the "x == false" instead of "!x" as well: it's more explicit / readable.

        Show
        Michael McCandless added a comment - I rather like the "x == false" instead of "!x" as well: it's more explicit / readable.
        Hide
        ASF subversion and git services added a comment -

        Commit 1518997 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1518997 ]

        LUCENE-5183: remove BinaryDocValues.MISSING

        Show
        ASF subversion and git services added a comment - Commit 1518997 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1518997 ] LUCENE-5183 : remove BinaryDocValues.MISSING
        Hide
        ASF subversion and git services added a comment -

        Commit 1519003 from Robert Muir in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1519003 ]

        LUCENE-5183: remove BinaryDocValues.MISSING

        Show
        ASF subversion and git services added a comment - Commit 1519003 from Robert Muir in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1519003 ] LUCENE-5183 : remove BinaryDocValues.MISSING
        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development