Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5164

Remove the OOM catching in SimpleFSDirectory and NIOFSDirectory

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Followup from LUCENE-5161:
      In former times we added the OOM cactching in NIOFSDir and SimpleFSDir because nobody understand why the OOM could happen on FileChannel.read() or SimpleFSDir.read(). By reading the Java code its easy to understand (it allocates direct buffers with same size as the requested length to read). As we have chunking now reduce to a few kilobytes it cannot happen anymore that we get spurious OOMs.

      In fact we might hide a real OOM! So we should remove it.

      I am also not sure if we should make chunk size configureable in FSDirectory at all! It makes no sense to me (it was in fact only added for people that hit the OOM to fine-tune).

      In my opinion we should remove the setter in trunk and keep it deprecated in 4.x. The buf size is then in trunk equal to the defaults from LUCENE-5161.

        Attachments

        1. LUCENE-5164-4x.patch
          58 kB
          Uwe Schindler
        2. LUCENE-5164.patch
          9 kB
          Uwe Schindler
        3. LUCENE-5164.patch
          19 kB
          Uwe Schindler
        4. LUCENE-5164.patch
          24 kB
          Uwe Schindler
        5. LUCENE-5164.patch
          24 kB
          Uwe Schindler
        6. LUCENE-5164.patch
          24 kB
          Uwe Schindler

          Issue Links

            Activity

              People

              • Assignee:
                thetaphi Uwe Schindler
                Reporter:
                thetaphi Uwe Schindler
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: