Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5155

Add OrdinalValueResolver in favor of FacetRequest.getValueOf

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.5, 6.0
    • modules/facet
    • None
    • New, Patch Available

    Description

      FacetRequest.getValueOf is responsible for resolving an ordinal's value. It is given FacetArrays, and typically does something like arrays.getIntArray()[ord] – for every ordinal! The purpose of this method is to allow special requests, e.g. average, to do some post processing on the values, that couldn't be done during aggregation.

      I feel that getValueOf is in the wrong place – the calls to getInt/FloatArray are really redundant. Also, if an aggregator maintains some statistics by which it needs to "correct" the aggregated values, it's not trivial to pass it from the aggregator to the request.

      Therefore I would like to make the following changes:

      • Remove FacetRequest.getValueOf and .getFacetArraysSource
      • Add FacetsAggregator.createOrdinalValueResolver which takes the FacetArrays and has a simple API .valueOf(ordinal).
      • Modify the FacetResultHandlers to use OrdValResolver.

      This allows an OVR to initialize the right array instance(s) in the ctor, and return the value of the requested ordinal, without doing arrays.getArray() calls.

      Will post a patch shortly.

      Attachments

        1. LUCENE-5155.patch
          51 kB
          Shai Erera

        Activity

          People

            shaie Shai Erera
            shaie Shai Erera
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment