Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5152

Lucene FST is not immutable

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 4.4
    • 4.5, 6.0
    • core/FSTs
    • None
    • New, Patch Available

    Description

      a spinnoff from LUCENE-5120 where the analyzing suggester modified a returned output from and FST (BytesRef) which caused sideffects in later execution.

      I added an assertion into the FST that checks if a cached root arc is modified and in-fact this happens for instance in our MemoryPostingsFormat and I bet we find more places. We need to think about how to make this less trappy since it can cause bugs that are super hard to find.

      Attachments

        1. LUCENE-5152.patch
          1.0 kB
          Michael McCandless
        2. LUCENE-5152.patch
          8 kB
          Simon Willnauer
        3. LUCENE-5152.patch
          11 kB
          Simon Willnauer
        4. LUCENE-5152.patch
          4 kB
          Simon Willnauer

        Activity

          People

            Unassigned Unassigned
            simonw Simon Willnauer
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: