Lucene - Core
  1. Lucene - Core
  2. LUCENE-5146

AnalyzingSuggester sort order doesn't respect the actual weight

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.4
    • Fix Version/s: 4.5, 6.0
    • Component/s: modules/spellchecker
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Uwe would say: "sorry but your code is wrong". We don't actually read the weight value in AnalyzingComparator which can cause really odd suggestions since we read parts of the input as the weight. Non of our tests catches that so I will go ahead and add some tests for it as well.

      1. LUCENE-5146.patch
        9 kB
        Simon Willnauer
      2. LUCENE-5146.patch
        9 kB
        Simon Willnauer

        Activity

        Hide
        Simon Willnauer added a comment -

        here is a patch

        Show
        Simon Willnauer added a comment - here is a patch
        Hide
        Uwe Schindler added a comment -

        Sorry but your code is of course wrong

        Show
        Uwe Schindler added a comment - Sorry but your code is of course wrong
        Hide
        Simon Willnauer added a comment -

        new patch including CHANGES.TXT entry and removed compiler warnings caused by the test helper.

        Show
        Simon Willnauer added a comment - new patch including CHANGES.TXT entry and removed compiler warnings caused by the test helper.
        Hide
        ASF subversion and git services added a comment -

        Commit 1508382 from Simon Willnauer in branch 'dev/trunk'
        [ https://svn.apache.org/r1508382 ]

        LUCENE-5146: AnalyzingSuggester sort order doesn't respect the actual weight

        Show
        ASF subversion and git services added a comment - Commit 1508382 from Simon Willnauer in branch 'dev/trunk' [ https://svn.apache.org/r1508382 ] LUCENE-5146 : AnalyzingSuggester sort order doesn't respect the actual weight
        Hide
        ASF subversion and git services added a comment -

        Commit 1508384 from Simon Willnauer in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1508384 ]

        LUCENE-5146: AnalyzingSuggester sort order doesn't respect the actual weight

        Show
        ASF subversion and git services added a comment - Commit 1508384 from Simon Willnauer in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1508384 ] LUCENE-5146 : AnalyzingSuggester sort order doesn't respect the actual weight
        Hide
        Michael McCandless added a comment -

        Thanks Simon!

        Show
        Michael McCandless added a comment - Thanks Simon!
        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            Simon Willnauer
            Reporter:
            Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development