Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-511

New BufferedIndexOutput optimization fails to update bufferStart

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9, 2.0.0
    • Component/s: core/store
    • Labels:
      None

      Description

      New BufferIndexOutput optimization of writeBytes fails to update bufferStart under some conditions. Test case and fix attached.

      1. BufferedIndexOutput.java
        4 kB
        Shay Banon
      2. BufferedIndexOutput.patch
        2 kB
        Steven Tamm
      3. RAMOutputTest.java
        0.4 kB
        Shay Banon

        Activity

        Hide
        cutting Doug Cutting added a comment -

        Can you please package this as a single patch file, generated with 'svn diff' while connected to the Lucene root? Thanks!

        Show
        cutting Doug Cutting added a comment - Can you please package this as a single patch file, generated with 'svn diff' while connected to the Lucene root? Thanks!
        Hide
        kimchy Shay Banon added a comment -

        My lucene root is not as clean as it should be. Don't have time to do that, sorry... . Simple copy and paste the BufferedIndexOutput to your local one, and check for changes (there will be only one line).

        The test, if you want to add it, should be dropped to its package location.

        Sorry for this, have so many other things to do, and its not a big change.

        Show
        kimchy Shay Banon added a comment - My lucene root is not as clean as it should be. Don't have time to do that, sorry... . Simple copy and paste the BufferedIndexOutput to your local one, and check for changes (there will be only one line). The test, if you want to add it, should be dropped to its package location. Sorry for this, have so many other things to do, and its not a big change.
        Hide
        cutting Doug Cutting added a comment -

        I have committed a patch for this.

        Show
        cutting Doug Cutting added a comment - I have committed a patch for this.
        Hide
        tamm Steven Tamm added a comment -

        Here's the files in patch format.

        Show
        tamm Steven Tamm added a comment - Here's the files in patch format.

          People

          • Assignee:
            Unassigned
            Reporter:
            kimchy Shay Banon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development