Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5101

make it easier to plugin different bitset implementations to CachingWrapperFilter

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Currently this is possible, but its not so friendly:

        protected DocIdSet docIdSetToCache(DocIdSet docIdSet, AtomicReader reader) throws IOException {
          if (docIdSet == null) {
            // this is better than returning null, as the nonnull result can be cached
            return EMPTY_DOCIDSET;
          } else if (docIdSet.isCacheable()) {
            return docIdSet;
          } else {
            final DocIdSetIterator it = docIdSet.iterator();
            // null is allowed to be returned by iterator(),
            // in this case we wrap with the sentinel set,
            // which is cacheable.
            if (it == null) {
              return EMPTY_DOCIDSET;
            } else {
      /* INTERESTING PART */
              final FixedBitSet bits = new FixedBitSet(reader.maxDoc());
              bits.or(it);
              return bits;
      /* END INTERESTING PART */
            }
          }
        }
      

      Is there any value to having all this other logic in the protected API? It seems like something thats not useful for a subclass... Maybe this stuff can become final, and "INTERESTING PART" calls a simpler method, something like:

      protected DocIdSet cacheImpl(DocIdSetIterator iterator, AtomicReader reader) {
        final FixedBitSet bits = new FixedBitSet(reader.maxDoc());
        bits.or(iterator);
        return bits;
      }
      

        Attachments

        1. DocIdSetBenchmark.java
          8 kB
          Adrien Grand
        2. LUCENE-5101.patch
          24 kB
          Adrien Grand
        3. LUCENE-5101.patch
          24 kB
          Adrien Grand
        4. LUCENE-5101.patch
          7 kB
          Robert Muir
        5. LUCENE-5101.patch
          3 kB
          Robert Muir

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              rcmuir Robert Muir
            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: