Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-510

IndexOutput.writeString() should write length in bytes

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.4
    • Component/s: core/store
    • Labels:
      None

      Description

      We should change the format of strings written to indexes so that the length of the string is in bytes, not Java characters. This issue has been discussed at:

      http://www.mail-archive.com/java-dev@lucene.apache.org/msg01970.html

      We must increment the file format number to indicate this change. At least the format number in the segments file should change.

      I'm targetting this for 2.1, i.e., we shouldn't commit it to trunk until after 2.0 is released, to minimize incompatible changes between 1.9 and 2.0 (other than removal of deprecated features).

        Attachments

        1. LUCENE-510.take2.patch
          120 kB
          Michael McCandless
        2. LUCENE-510.patch
          51 kB
          Michael McCandless
        3. SortExternal.java
          15 kB
          Marvin Humphrey
        4. TestSortExternal.java
          6 kB
          Marvin Humphrey
        5. strings.diff
          27 kB
          Marvin Humphrey

          Issue Links

            Activity

              People

              • Assignee:
                mikemccand Michael McCandless
                Reporter:
                cutting Doug Cutting
              • Votes:
                5 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: