[LUCENE-5083] Wasted work in FuzzySet.getNearestSetSize

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 4.3.1
• Component/s: core/codecs
• Labels: patch performance

Environment

any

• Lucene Fields: New, Patch Available
• Assignee: Unassigned
• Reporter: Adrian Nistor
• Created: 29/Jun/13 21:28
• Updated: 28/Aug/22 13:48

Description

The problem appears in version 4.3.1 and in revision 1498027. I
attached a two-line patch that fixes it.

In method "FuzzySet.getNearestSetSize", the loop over
"usableBitSetSizes" keeps overriding "result" with
"usableBitSetSizes[i]". Therefore, only the last written value is
visible out of the loop and all the other writes and iterations are
not necessary. The patch iterates from the end of "usableBitSetSizes"
and breaks the first time when "result" is set.