Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5050

CompressingStoredFieldsReader should close the index file as soon as it has been read

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.3.1
    • Fix Version/s: 4.4, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Although CompressingStoredFieldsReader loads the stored fields index into memory, it only closes the index file in close(). Closing at the end of the constructor should help save file descriptors.

      The same idea applies to CompressingTermVectorsReader.

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch which closes the index file in the constructor for both CompressingStoredFieldsReader and CompressingTermVectorsReader.

        Show
        jpountz Adrien Grand added a comment - Here is a patch which closes the index file in the constructor for both CompressingStoredFieldsReader and CompressingTermVectorsReader.
        Hide
        rcmuir Robert Muir added a comment -

        +1

        Show
        rcmuir Robert Muir added a comment - +1
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [branch_4x commit] jpountz
        http://svn.apache.org/viewvc?view=revision&revision=1491909

        LUCENE-5050: Close the stored fields and term vectors index files eagerly (merged from r1491889).

        Show
        commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] jpountz http://svn.apache.org/viewvc?view=revision&revision=1491909 LUCENE-5050 : Close the stored fields and term vectors index files eagerly (merged from r1491889).
        Hide
        jpountz Adrien Grand added a comment -

        Thanks Robert.

        Show
        jpountz Adrien Grand added a comment - Thanks Robert.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        steve_rowe Steve Rowe added a comment - Bulk close resolved 4.4 issues

          People

          • Assignee:
            jpountz Adrien Grand
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development