[LUCENE-5041] wasted work in CheckIndex.checkIndex(List)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3
• Fix Version/s: 4.4, 6.0
• Component/s: core/index
• Labels: patch performance

Environment

any

• Lucene Fields: New, Patch Available
• Assignee: Unassigned
• Reporter: Adrian Nistor
• Created: 06/Jun/13 14:36
• Updated: 28/Aug/22 13:47
• Resolved: 06/Jun/13 16:32

Description

The problem appears in version 4.3.0 and in revision 1490286. I
attached a two-line patch that fixes it.

In method "CheckIndex.checkIndex(List<String>)", the loop over
"onlySegments" should not be executed when "infoStream" is "null".
When "infoStream" is "null" the loop produces no results. The patch
just flips the order of the "if" and "for" statements.

Method "collect" in class "MultiComparatorNonScoringCollector" has a
similar loop (the last loop in the method over "comparators"), and
this loop is not executed when "queueFull" is false, just like in the
proposed patch.