[LUCENE-5038] Don't call MergePolicy / IndexWriter during DWPT Flush

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.3, 6.0
• Fix Version/s: 4.4, 6.0
• Component/s: core/index
• Lucene Fields: New, Patch Available
• Assignee: Simon Willnauer
• Reporter: Simon Willnauer
• Created: 06/Jun/13 13:15
• Updated: 28/Aug/22 13:47
• Resolved: 14/Jun/13 19:34

Description

We currently consult the indexwriter -> merge policy to decide if we need to write CFS or not which is bad in many ways.

• we should call mergepolicy only during merges
• we should never sync on IW during DWPT flush
• we should be able to make the decision if we need to write CFS or not before flush, ie. we could write parts of the flush directly to CFS or even start writing stored fields directly.
• in the NRT case it might make sense to write all flushes to CFS to minimize filedescriptors independent of the index size.

I wonder if we can use a simple boolean for this in the IWC and get away with not consulting merge policy. This would simplify concurrency a lot here already.

Issue Links

• is related to: SOLR-4934 Prevent runtime failure if users use initargs "useCompoundFile" setting on LogMergePolicy or TieredMergePolicy
• is related to: SOLR-4941 useCompoundFile default has changed, simple config option no longer seems to work
• relates to: SOLR-4926 I am seeing RecoveryZkTest and ChaosMonkeySafeLeaderTest fail often on trunk.