Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4980

Can't use DrillSideways with both RangeFacetRequest and non-RangeFacetRequest

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4, 6.0
    • Component/s: modules/facet
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I tried to combine these two and there were several issues:

      • It's ... really tricky to manage the two different
        FacetAccumulators across that N FacetCollectors that DrillSideways
        creates ... to fix this I added a new MultiFacetsAccumulator that
        switches for you.
      • There was still one place in DS/DDQ that wasn't properly handling
        a non-Term drill-down.
      • There was a bug in the "collector method" for DrillSideways
        whereby if a given segment had no hits, it was skipped, which is
        incorrect because it must still be visited to tally up the
        sideways counts.
      • Separately I noticed that DrillSideways was doing too much work:
        it would count up drill-down counts and drill-sideways counts
        against the same dim (but then discard the drill-down counts in
        the end).

        Attachments

        1. LUCENE-4980.patch
          23 kB
          Michael McCandless
        2. LUCENE-4980.patch
          23 kB
          Michael McCandless

          Activity

            People

            • Assignee:
              mikemccand Michael McCandless
              Reporter:
              mikemccand Michael McCandless
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: