Lucene - Core
  1. Lucene - Core
  2. LUCENE-4976

PersistentSnapshotDeletionPolicy should save to a single file

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4, Trunk
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today it creates a single-document Lucene index, and calls commit() after each snapshot/release.

      I think we can just use a single file instead, and remove Closeable.

      1. LUCENE-4976.patch
        17 kB
        Michael McCandless
      2. LUCENE-4976.patch
        30 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        patch.

        Show
        Michael McCandless added a comment - patch.
        Hide
        Shai Erera added a comment -

        looks good!

        Show
        Shai Erera added a comment - looks good!
        Hide
        Michael McCandless added a comment -

        New patch, added a test case, and fixed PSDP to detect if you try to snapshot/release when it's not being used by an IW ... I think it's ready.

        Show
        Michael McCandless added a comment - New patch, added a test case, and fixed PSDP to detect if you try to snapshot/release when it's not being used by an IW ... I think it's ready.
        Hide
        Shai Erera added a comment -

        +1!

        Show
        Shai Erera added a comment - +1!
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1478726

        LUCENE-4976: use single file to hold PersistentSnapshotDeletionPolicy state on disk

        Show
        Commit Tag Bot added a comment - [trunk commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1478726 LUCENE-4976 : use single file to hold PersistentSnapshotDeletionPolicy state on disk
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1478730

        LUCENE-4976: use single file to hold PersistentSnapshotDeletionPolicy state on disk

        Show
        Commit Tag Bot added a comment - [branch_4x commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1478730 LUCENE-4976 : use single file to hold PersistentSnapshotDeletionPolicy state on disk
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1478854

        LUCENE-4976: fix Solr IndexDeletionPolicy impls to handle empty commits onInit

        Show
        Commit Tag Bot added a comment - [branch_4x commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1478854 LUCENE-4976 : fix Solr IndexDeletionPolicy impls to handle empty commits onInit
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1478855

        LUCENE-4976: fix Solr IndexDeletionPolicy impls to handle empty commits onInit

        Show
        Commit Tag Bot added a comment - [trunk commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1478855 LUCENE-4976 : fix Solr IndexDeletionPolicy impls to handle empty commits onInit
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1479394

        LUCENE-4976: add missing sync / delete old save files

        Show
        Commit Tag Bot added a comment - [trunk commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1479394 LUCENE-4976 : add missing sync / delete old save files
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] mikemccand
        http://svn.apache.org/viewvc?view=revision&revision=1479395

        LUCENE-4976: add missing sync / delete old save files

        Show
        Commit Tag Bot added a comment - [branch_4x commit] mikemccand http://svn.apache.org/viewvc?view=revision&revision=1479395 LUCENE-4976 : add missing sync / delete old save files
        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development