Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4970

NGramPhraseQuery is not boosted.

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 4.1
        • Fix Version/s: 4.3.1
        • Component/s: core/search
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          If I apply setBoost() method to NGramPhraseQuery, Score will not change.

          I think, setBoost() is forgatten after optimized in rewrite() method.

          1. Text File
            LUCENE-4970.patch
            2 kB
            Shingo Sasaki

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jpountz Adrien Grand added a comment -

            Hi Shingo, you are right. NGramPhraseQuery.rewrite should propagate the boost to the rewritten query. Would yo like to submit a patch? (see http://wiki.apache.org/lucene-java/HowToContribute)

            Show
            jpountz Adrien Grand added a comment - Hi Shingo, you are right. NGramPhraseQuery.rewrite should propagate the boost to the rewritten query. Would yo like to submit a patch? (see http://wiki.apache.org/lucene-java/HowToContribute )
            Hide
            Permalink
            sasashin Shingo Sasaki added a comment -

            Hi Adrien,

            > Would yo like to submit a patch?

            Of course. Thank you for giving an opportunity.

            Because I hadn't written open source's patches yet, it became a good experience.

            Show
            sasashin Shingo Sasaki added a comment - Hi Adrien, > Would yo like to submit a patch? Of course. Thank you for giving an opportunity. Because I hadn't written open source's patches yet, it became a good experience.
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] jpountz
            http://svn.apache.org/viewvc?view=revision&revision=1478225

            LUCENE-4970: Fix boost value of rewritten NGramPhraseQuery.

            Show
            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] jpountz http://svn.apache.org/viewvc?view=revision&revision=1478225 LUCENE-4970 : Fix boost value of rewritten NGramPhraseQuery.
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] jpountz
            http://svn.apache.org/viewvc?view=revision&revision=1478227

            LUCENE-4970: Fix boost value of rewritten NGramPhraseQuery.

            Show
            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] jpountz http://svn.apache.org/viewvc?view=revision&revision=1478227 LUCENE-4970 : Fix boost value of rewritten NGramPhraseQuery.
            Hide
            Permalink
            jpountz Adrien Grand added a comment -

            Committed, thank you Shingo!

            Show
            jpountz Adrien Grand added a comment - Committed, thank you Shingo!
            Hide
            Permalink
            steve_rowe Steve Rowe added a comment -

            If there are no objections, I'd like to backport this to 4.3.1.

            Show
            steve_rowe Steve Rowe added a comment - If there are no objections, I'd like to backport this to 4.3.1.
            Hide
            Permalink
            jpountz Adrien Grand added a comment -

            Sounds good!

            Show
            jpountz Adrien Grand added a comment - Sounds good!
            Hide
            Permalink
            shalinmangar Shalin Shekhar Mangar added a comment -

            Back ported to 4.3.1 r1483347

            Show
            shalinmangar Shalin Shekhar Mangar added a comment - Back ported to 4.3.1 r1483347
            Hide
            Permalink
            shalinmangar Shalin Shekhar Mangar added a comment -

            Bulk closing after 4.3.1 release

            Show
            shalinmangar Shalin Shekhar Mangar added a comment - Bulk closing after 4.3.1 release

              People

              • Assignee:
                jpountz Adrien Grand
                Reporter:
                sasashin Shingo Sasaki
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development