Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4959

Incorrect return value from SimpleNaiveBayesClassifier.assignClass

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 4.2.1, 6.0
        • Fix Version/s: None
        • Component/s: None
        • Labels:
        • Lucene Fields:
          New

          Description

          The local copy of BytesRef referenced by foundClass is affected by subsequent TermsEnum.iterator.next() calls as the shared BytesRef.bytes changes.

          If a term "test" gives a good match and a next term in the terms collection is "classification" with a lower match score then the return result will be "clas"

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            alexeyline Alexey Kutin added a comment -

            Replaced BytesRef.clone() with BytesRef.deepCopyOf() to let it hold on to the instance while iterating.

            Also had to change unit tests to expose the issue first.

            Show
            alexeyline Alexey Kutin added a comment - Replaced BytesRef.clone() with BytesRef.deepCopyOf() to let it hold on to the instance while iterating. Also had to change unit tests to expose the issue first.
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] jpountz
            http://svn.apache.org/viewvc?view=revision&revision=1476650

            LUCENE-4959: Fix incorrect return value in SimpleNaiveBayesClassifier.assignClass.

            Show
            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] jpountz http://svn.apache.org/viewvc?view=revision&revision=1476650 LUCENE-4959 : Fix incorrect return value in SimpleNaiveBayesClassifier.assignClass.
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] jpountz
            http://svn.apache.org/viewvc?view=revision&revision=1476651

            LUCENE-4959: Fix incorrect return value in SimpleNaiveBayesClassifier.assignClass.

            Show
            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] jpountz http://svn.apache.org/viewvc?view=revision&revision=1476651 LUCENE-4959 : Fix incorrect return value in SimpleNaiveBayesClassifier.assignClass.
            Hide
            Permalink
            jpountz Adrien Grand added a comment -

            Thanks Alexey!

            Show
            jpountz Adrien Grand added a comment - Thanks Alexey!
            Hide
            Permalink
            teofili Tommaso Teofili added a comment -

            thanks Alexey for reporting and fixing and Adrien for taking care of it, I was offline and could notice it just now

            Show
            teofili Tommaso Teofili added a comment - thanks Alexey for reporting and fixing and Adrien for taking care of it, I was offline and could notice it just now

              People

              • Assignee:
                jpountz Adrien Grand
                Reporter:
                alexeyline Alexey Kutin
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development