Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4939

Join's TermsIncludingScoreQuery Weight has wrong normalization

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: modules/join
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      In the Join module, TermsIncludingScoreQuery's Weight implementation looks suspiciously wrong. It creates a Weight based on the original query and delegates a couple calls to it in getValueForNormalization() and normalize() – ok fine. But then it doesn't do anything with it! Furthermore, the original query has already been run by this point anyway.

      Question: Should the original query, which currently runs separately (see JoinUtil), participate in the Weight normalization of the main query? It would be tricky to wire all this together based on the current structure but arguably that is more correct.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dsmiley David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: