Lucene - Core
  1. Lucene - Core
  2. LUCENE-4923

remove minShouldMatch/speed up DisjunctionSumScorer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.3
    • Fix Version/s: 4.3, 6.0
    • Component/s: core/query/scoring
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      LUCENE-4571 added a MinShouldMatchScorer: capable of using advance() on subscorers for minShouldMatch > 1.

      However, we didn't yet cleanup the (now dead) minShouldMatch logic from DisjunctionSumScorer: which is now only used for pure disjunctions. This can also give some reasonable performance improvements for in-order collection.

        Activity

        Hide
        Robert Muir added a comment -

        Here's a patch. Just cleaning house on the minShouldMatch gives about a 10% improvement on luceneutil, but supporting pure disjunctions as a top-level scorer from BooleanWeight is even better (20%):

                            Task   QPS trunk      StdDev   QPS patch      StdDev                Pct diff
                      OrHighHigh       22.70      (6.5%)       27.45      (4.0%)   20.9% (   9% -   33%)
                       OrHighMed       31.17      (6.7%)       38.06      (4.6%)   22.1% (  10% -   35%)
                       OrHighLow       71.52      (7.1%)       87.48      (5.5%)   22.3% (   9% -   37%)
        
        Show
        Robert Muir added a comment - Here's a patch. Just cleaning house on the minShouldMatch gives about a 10% improvement on luceneutil, but supporting pure disjunctions as a top-level scorer from BooleanWeight is even better (20%): Task QPS trunk StdDev QPS patch StdDev Pct diff OrHighHigh 22.70 (6.5%) 27.45 (4.0%) 20.9% ( 9% - 33%) OrHighMed 31.17 (6.7%) 38.06 (4.6%) 22.1% ( 10% - 35%) OrHighLow 71.52 (7.1%) 87.48 (5.5%) 22.3% ( 9% - 37%)
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Michael McCandless added a comment -

        I think Rob committed this to 4.3/5.x? No message from commit bot ... I think this was when it was sleeping.

        Show
        Michael McCandless added a comment - I think Rob committed this to 4.3/5.x? No message from commit bot ... I think this was when it was sleeping.
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development